-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(anthropic): Add partial json support to streams #3674
Conversation
Adds partial json to the content block when streaming.
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #3674 +/- ##
==========================================
- Coverage 79.55% 79.55% -0.01%
==========================================
Files 140 140
Lines 15515 15517 +2
Branches 2629 2630 +1
==========================================
+ Hits 12343 12344 +1
Misses 2338 2338
- Partials 834 835 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for that!
@kwnath could you fix the failing tests please? Thanks! |
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After fixing some tests, this is now ready to be merged! Thanks again @kwnath for the fix!
Description
I actually forgotten to add the most crucial in PR where we wanted to add support for
partial_json
in tool calling when streaming. This PR fixes that.cc @antonpirker apologies for this!