Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[breaking] Enable Django cache_spans by default #3994

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

BYK
Copy link
Member

@BYK BYK commented Jan 24, 2025

This reverts commit 955108e (#3791) and simply enables cache_spans by default..

This reverts commit 955108e (#3791) and simply enables `cache_spans` by default..
@BYK BYK requested a review from antonpirker January 24, 2025 21:55
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.56%. Comparing base (4d64c4e) to head (42c3d41).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3994   +/-   ##
=======================================
  Coverage   79.55%   79.56%           
=======================================
  Files         140      140           
  Lines       15512    15509    -3     
  Branches     2628     2628           
=======================================
- Hits        12341    12339    -2     
  Misses       2335     2335           
+ Partials      836      835    -1     
Files with missing lines Coverage Δ
sentry_sdk/integrations/django/__init__.py 81.48% <ø> (ø)
sentry_sdk/integrations/django/caching.py 92.70% <100.00%> (-0.23%) ⬇️

... and 1 file with indirect coverage changes

@antonpirker antonpirker added the Breaking change needs to go out in a major label Feb 20, 2025
@antonpirker antonpirker changed the title breaking: Enable Django cache_spans by default [breaking] Enable Django cache_spans by default Feb 20, 2025
@antonpirker antonpirker changed the title [breaking] Enable Django cache_spans by default [breaking] Enable Django cache_spans by default Feb 20, 2025
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good.

We will probably release this with version 3.0 of the SDK. (which will be done in a couple of weeks/months)

Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just put this here that not accidentally someone merges this. see my other review above for the real review :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking change needs to go out in a major SDK 3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants