-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[breaking] Enable Django cache_spans
by default
#3994
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #3994 +/- ##
=======================================
Coverage 79.55% 79.56%
=======================================
Files 140 140
Lines 15512 15509 -3
Branches 2628 2628
=======================================
- Hits 12341 12339 -2
Misses 2335 2335
+ Partials 836 835 -1
|
cache_spans
by default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good.
We will probably release this with version 3.0 of the SDK. (which will be done in a couple of weeks/months)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just put this here that not accidentally someone merges this. see my other review above for the real review :-)
This reverts commit 955108e (#3791) and simply enables
cache_spans
by default..