-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set HTTP client breadcrumb level based on status code #4090
Merged
sentrivana
merged 4 commits into
potel-base
from
ivana/potelport-http-client-breadcrumb-statuses
Feb 26, 2025
Merged
Set HTTP client breadcrumb level based on status code #4090
sentrivana
merged 4 commits into
potel-base
from
ivana/potelport-http-client-breadcrumb-statuses
Feb 26, 2025
+35
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 158 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
antonpirker
approved these changes
Feb 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
This was referenced Feb 26, 2025
sentrivana
added a commit
that referenced
this pull request
Feb 27, 2025
Oversight from #4090 -- forgot to update the breadcrumb level created by the async httpx client Makes all Network tests green.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On potel-base, we got rid of the
maybe_create_breadcrumbs
function in favor of creating breadcrumbs manually, so the new breadcrumb level logic needs to go directly in the affected integrations.Closes #4066