Skip to content

ref(scope): Properly type Scope.root_span #4273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 24, 2025

Conversation

szokeasaurusrex
Copy link
Member

@szokeasaurusrex szokeasaurusrex commented Apr 10, 2025

Currently, this property has type Any, but it can now be changed to Optional[Span]

Depends on:

@szokeasaurusrex szokeasaurusrex requested a review from a team as a code owner April 10, 2025 11:31
@szokeasaurusrex szokeasaurusrex requested review from antonpirker and sentrivana and removed request for a team April 10, 2025 11:31
Copy link

codecov bot commented Apr 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 83.52%. Comparing base (2d51839) to head (c103e7f).
Report is 24 commits behind head on potel-base.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/integrations/huey.py 0.00% 8 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           potel-base    #4273      +/-   ##
==============================================
- Coverage       83.54%   83.52%   -0.03%     
==============================================
  Files             144      144              
  Lines           14631    14634       +3     
  Branches         2325     2327       +2     
==============================================
- Hits            12224    12223       -1     
- Misses           1690     1693       +3     
- Partials          717      718       +1     
Files with missing lines Coverage Δ
sentry_sdk/scope.py 82.38% <ø> (ø)
sentry_sdk/integrations/huey.py 16.04% <0.00%> (-0.62%) ⬇️

... and 3 files with indirect coverage changes

Currently, this property has type `Any`, but it can now be changed to `Optional[Span]`

Depends on:
  - #4263
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/root_span-type branch from cbce9ed to 6d441a1 Compare April 10, 2025 12:28
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/transaction-root-span branch from 7f14b64 to b30574a Compare April 10, 2025 12:28
@szokeasaurusrex szokeasaurusrex requested a review from a team as a code owner April 10, 2025 12:28
Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Base automatically changed from szokeasaurusrex/transaction-root-span to potel-base April 10, 2025 13:17
@antonpirker antonpirker merged commit 4046951 into potel-base Apr 24, 2025
126 of 127 checks passed
@antonpirker antonpirker deleted the szokeasaurusrex/root_span-type branch April 24, 2025 11:00
antonpirker pushed a commit that referenced this pull request Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants