-
Notifications
You must be signed in to change notification settings - Fork 535
ref(scope): Properly type Scope.root_span
#4273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## potel-base #4273 +/- ##
==============================================
- Coverage 83.54% 83.52% -0.03%
==============================================
Files 144 144
Lines 14631 14634 +3
Branches 2325 2327 +2
==============================================
- Hits 12224 12223 -1
- Misses 1690 1693 +3
- Partials 717 718 +1
|
Currently, this property has type `Any`, but it can now be changed to `Optional[Span]` Depends on: - #4263
cbce9ed
to
6d441a1
Compare
7f14b64
to
b30574a
Compare
sentrivana
approved these changes
Apr 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
Base automatically changed from
szokeasaurusrex/transaction-root-span
to
potel-base
April 10, 2025 13:17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, this property has type
Any
, but it can now be changed toOptional[Span]
Depends on:
transaction
withroot_span
#4263