Skip to content

Cleaning up types #4309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Cleaning up types #4309

wants to merge 2 commits into from

Conversation

antonpirker
Copy link
Member

@antonpirker antonpirker commented Apr 16, 2025

Reorganize our types so they are easy for humans and IDEs to find and use.

As we will support Python 3.8+ we can refrain from using typing_extension

Fixes #4127

Copy link

codecov bot commented Apr 16, 2025

❌ 5 Tests Failed:

Tests completed Failed Passed Skipped
9446 5 9441 2011
View the top 3 failed test(s) by shortest run time
tests.integrations.threading.test_threading test_spans_from_multiple_threads[propagate_scope=False]
Stack Traces | 0.108s run time
.../integrations/threading/test_threading.py:246: in test_spans_from_multiple_threads
    (event,) = events
E   ValueError: too many values to unpack (expected 1)
tests.integrations.threading.test_threading test_spans_from_multiple_threads[propagate_scope=False]
Stack Traces | 0.11s run time
.../integrations/threading/test_threading.py:246: in test_spans_from_multiple_threads
    (event,) = events
E   ValueError: too many values to unpack (expected 1)
tests.integrations.threading.test_threading test_spans_from_multiple_threads[propagate_scope=False]
Stack Traces | 0.125s run time
.../integrations/threading/test_threading.py:246: in test_spans_from_multiple_threads
    (event,) = events
E   ValueError: too many values to unpack (expected 1)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@antonpirker antonpirker deleted the antonpirker/types branch April 17, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant