-
Notifications
You must be signed in to change notification settings - Fork 535
Make all relevant types public #4315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #4315 +/- ##
==========================================
+ Coverage 80.28% 80.30% +0.01%
==========================================
Files 142 142
Lines 15925 15929 +4
Branches 2724 2724
==========================================
+ Hits 12786 12792 +6
+ Misses 2263 2262 -1
+ Partials 876 875 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Although, I would recommend omitting the TODO
comments.
@@ -220,7 +220,9 @@ class SDKInfo(TypedDict): | |||
tuple[None, None, None], | |||
] | |||
|
|||
# TODO: Make a proper type definition for this (PRs welcome!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nit] I'd suggest we just remove these TODO
comments and make GitHub issues for them; I think TODO
comments will just get ignored
# TODO: Make a proper type definition for this (PRs welcome!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will keep them. Maybe someone wants to earn some internet points and creates nice types here :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay fair enough 😂
Make types that users can use when configuring the SDK public.
Accompaniyng docs update: getsentry/sentry-docs#13437
Fixes #4127