Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(samples): Share monorepo config, remove broken promises resolve, add react to blocked packages #4494

Merged
merged 3 commits into from
Jan 31, 2025

Conversation

krystofwoldrich
Copy link
Member

📢 Type of change

  • Bugfix
  • Refactoring

📜 Description

This PR extracts all monorepo config to one shared package for all sample and perf applications.

This PR adds react package to the blocked packages, this means all react imports will be resolved from the projectRoot/node_modules which mitigates errors like can't call useState on undefined and others caused by multiple react instances. (This allows UserFeedback to use functional components.)

💚 How did you test it?

sample apps

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

#skip-changelog

Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 445.06 ms 438.33 ms -6.74 ms
Size 17.75 MiB 20.11 MiB 2.36 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
cdf2f33 469.46 ms 462.17 ms -7.29 ms
7bc4d75 488.76 ms 473.28 ms -15.48 ms
e22745e 462.66 ms 458.10 ms -4.56 ms
f06c879 408.41 ms 424.54 ms 16.13 ms
e2b64fe 316.88 ms 330.23 ms 13.35 ms
c6f01ea 486.20 ms 486.98 ms 0.77 ms
34aba08 328.10 ms 342.84 ms 14.74 ms
b95b8af 454.05 ms 454.53 ms 0.48 ms
d8e8c67 448.79 ms 438.70 ms -10.09 ms
52c0562 453.04 ms 434.71 ms -18.33 ms

App size

Revision Plain With Sentry Diff
cdf2f33 17.74 MiB 20.08 MiB 2.34 MiB
7bc4d75 17.74 MiB 20.08 MiB 2.34 MiB
e22745e 17.74 MiB 20.08 MiB 2.34 MiB
f06c879 17.73 MiB 19.85 MiB 2.12 MiB
e2b64fe 17.73 MiB 19.80 MiB 2.07 MiB
c6f01ea 17.74 MiB 20.10 MiB 2.36 MiB
34aba08 17.73 MiB 19.80 MiB 2.07 MiB
b95b8af 17.73 MiB 20.11 MiB 2.37 MiB
d8e8c67 17.74 MiB 20.10 MiB 2.36 MiB
52c0562 17.73 MiB 20.11 MiB 2.38 MiB

Copy link
Contributor

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 436.15 ms 463.63 ms 27.48 ms
Size 7.15 MiB 8.38 MiB 1.23 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
416f465+dirty 407.26 ms 451.31 ms 44.05 ms
9f0f6c8+dirty 365.53 ms 419.16 ms 53.63 ms
70e6261+dirty 395.08 ms 408.12 ms 13.04 ms
d43a46b+dirty 417.65 ms 472.98 ms 55.33 ms
2ec71da+dirty 375.64 ms 431.59 ms 55.95 ms
12427f4+dirty 379.48 ms 400.92 ms 21.44 ms
5446992+dirty 371.61 ms 390.00 ms 18.39 ms
baa882f+dirty 449.30 ms 540.40 ms 91.10 ms
d0bf494+dirty 253.73 ms 308.23 ms 54.49 ms
9a3ca65+dirty 344.96 ms 358.92 ms 13.96 ms

App size

Revision Plain With Sentry Diff
416f465+dirty 7.15 MiB 8.37 MiB 1.22 MiB
9f0f6c8+dirty 7.15 MiB 8.37 MiB 1.22 MiB
70e6261+dirty 7.15 MiB 8.21 MiB 1.07 MiB
d43a46b+dirty 7.15 MiB 8.34 MiB 1.19 MiB
2ec71da+dirty 7.15 MiB 8.38 MiB 1.23 MiB
12427f4+dirty 7.15 MiB 8.12 MiB 997.78 KiB
5446992+dirty 7.15 MiB 8.12 MiB 999.45 KiB
baa882f+dirty 7.15 MiB 8.34 MiB 1.19 MiB
d0bf494+dirty 7.15 MiB 8.04 MiB 910.85 KiB
9a3ca65+dirty 7.15 MiB 8.09 MiB 962.83 KiB

Copy link
Contributor

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1217.82 ms 1226.36 ms 8.54 ms
Size 3.19 MiB 4.25 MiB 1.06 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
12427f4+dirty 1224.90 ms 1231.40 ms 6.50 ms
de59d3a+dirty 1241.17 ms 1249.16 ms 8.00 ms
63ed251+dirty 1223.27 ms 1222.94 ms -0.33 ms
5a22220+dirty 1246.18 ms 1249.61 ms 3.43 ms
416f465+dirty 1232.48 ms 1233.26 ms 0.78 ms
c398f67+dirty 1227.31 ms 1230.00 ms 2.69 ms
1332acb+dirty 1243.98 ms 1241.12 ms -2.86 ms
8fe7c9d+dirty 1227.63 ms 1245.28 ms 17.65 ms
5f03ae9+dirty 1237.79 ms 1241.02 ms 3.23 ms
9cab16b+dirty 1236.10 ms 1247.16 ms 11.06 ms

App size

Revision Plain With Sentry Diff
12427f4+dirty 2.92 MiB 3.44 MiB 533.29 KiB
de59d3a+dirty 2.92 MiB 3.67 MiB 772.59 KiB
63ed251+dirty 2.92 MiB 3.66 MiB 757.10 KiB
5a22220+dirty 2.92 MiB 3.48 MiB 575.81 KiB
416f465+dirty 2.92 MiB 3.67 MiB 772.44 KiB
c398f67+dirty 2.92 MiB 3.60 MiB 701.89 KiB
1332acb+dirty 2.92 MiB 3.67 MiB 772.45 KiB
8fe7c9d+dirty 3.19 MiB 4.24 MiB 1.06 MiB
5f03ae9+dirty 3.19 MiB 4.25 MiB 1.06 MiB
9cab16b+dirty 2.92 MiB 3.64 MiB 743.06 KiB

Copy link
Contributor

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1221.20 ms 1219.17 ms -2.04 ms
Size 2.63 MiB 3.68 MiB 1.05 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
488c9c5+dirty 1209.36 ms 1224.18 ms 14.82 ms
3aecc61+dirty 1237.75 ms 1237.42 ms -0.33 ms
9a3ca65+dirty 1247.06 ms 1274.58 ms 27.52 ms
0d3e677+dirty 1214.39 ms 1225.70 ms 11.31 ms
63ed251+dirty 1232.55 ms 1238.77 ms 6.22 ms
de59d3a+dirty 1223.73 ms 1236.28 ms 12.55 ms
c830127+dirty 1227.06 ms 1225.19 ms -1.88 ms
700cbf4+dirty 1234.59 ms 1227.71 ms -6.88 ms
80b2ce3+dirty 1265.92 ms 1268.60 ms 2.69 ms
8ab11b6+dirty 1203.23 ms 1206.02 ms 2.79 ms

App size

Revision Plain With Sentry Diff
488c9c5+dirty 2.63 MiB 3.69 MiB 1.05 MiB
3aecc61+dirty 2.36 MiB 3.12 MiB 778.58 KiB
9a3ca65+dirty 2.36 MiB 2.82 MiB 462.89 KiB
0d3e677+dirty 2.36 MiB 3.10 MiB 753.12 KiB
63ed251+dirty 2.36 MiB 3.10 MiB 752.55 KiB
de59d3a+dirty 2.36 MiB 3.11 MiB 760.16 KiB
c830127+dirty 2.36 MiB 3.12 MiB 778.80 KiB
700cbf4+dirty 2.36 MiB 3.08 MiB 734.22 KiB
80b2ce3+dirty 2.36 MiB 2.84 MiB 486.98 KiB
8ab11b6+dirty 2.36 MiB 3.11 MiB 759.83 KiB

Copy link
Collaborator

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this enhancement @krystofwoldrich 🙇
The changes LGTM and all the sample apps worked as expected for me 🚀

which mitigates errors like can't call useState on undefined and others caused by multiple react instances.

That's awesome 🥇 🎉

@krystofwoldrich krystofwoldrich merged commit d997097 into main Jan 31, 2025
70 checks passed
@krystofwoldrich krystofwoldrich deleted the kw-share-monorepo-logic branch January 31, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants