-
-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update Cocoa SDK to v8.44.0 #4495
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9e7fc09
to
b088cae
Compare
Android (new) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
9c48b2c+dirty | 270.82 ms | 321.12 ms | 50.30 ms |
d361d38+dirty | 257.72 ms | 318.76 ms | 61.04 ms |
52c0562+dirty | 401.23 ms | 435.65 ms | 34.42 ms |
9cab16b+dirty | 370.82 ms | 416.37 ms | 45.55 ms |
9f0f6c8+dirty | 365.53 ms | 419.16 ms | 53.63 ms |
e22745e+dirty | 415.50 ms | 448.76 ms | 33.26 ms |
5446992+dirty | 371.61 ms | 390.00 ms | 18.39 ms |
484813b+dirty | 411.65 ms | 456.02 ms | 44.37 ms |
62a750b+dirty | 370.78 ms | 376.73 ms | 5.96 ms |
8b86336+dirty | 484.80 ms | 537.94 ms | 53.14 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
9c48b2c+dirty | 7.15 MiB | 8.07 MiB | 947.16 KiB |
d361d38+dirty | 7.15 MiB | 8.08 MiB | 959.34 KiB |
52c0562+dirty | 7.15 MiB | 8.39 MiB | 1.24 MiB |
9cab16b+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
9f0f6c8+dirty | 7.15 MiB | 8.37 MiB | 1.22 MiB |
e22745e+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
5446992+dirty | 7.15 MiB | 8.12 MiB | 999.45 KiB |
484813b+dirty | 7.15 MiB | 8.34 MiB | 1.19 MiB |
62a750b+dirty | 7.15 MiB | 8.21 MiB | 1.06 MiB |
8b86336+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
Previous results on branch: deps/scripts/update-cocoa.sh
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
77364bc+dirty | 368.47 ms | 411.62 ms | 43.16 ms |
9c4a204+dirty | 440.30 ms | 484.81 ms | 44.52 ms |
62e1450+dirty | 363.60 ms | 401.13 ms | 37.53 ms |
7140a40+dirty | 419.33 ms | 463.16 ms | 43.83 ms |
a9355d1+dirty | 374.27 ms | 435.52 ms | 61.25 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
77364bc+dirty | 7.15 MiB | 8.36 MiB | 1.21 MiB |
9c4a204+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
62e1450+dirty | 7.15 MiB | 8.36 MiB | 1.21 MiB |
7140a40+dirty | 7.15 MiB | 8.36 MiB | 1.21 MiB |
a9355d1+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
iOS (legacy) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
488c9c5+dirty | 1209.36 ms | 1224.18 ms | 14.82 ms |
3aecc61+dirty | 1237.75 ms | 1237.42 ms | -0.33 ms |
9a3ca65+dirty | 1247.06 ms | 1274.58 ms | 27.52 ms |
0d3e677+dirty | 1214.39 ms | 1225.70 ms | 11.31 ms |
63ed251+dirty | 1232.55 ms | 1238.77 ms | 6.22 ms |
de59d3a+dirty | 1223.73 ms | 1236.28 ms | 12.55 ms |
c830127+dirty | 1227.06 ms | 1225.19 ms | -1.88 ms |
700cbf4+dirty | 1234.59 ms | 1227.71 ms | -6.88 ms |
80b2ce3+dirty | 1265.92 ms | 1268.60 ms | 2.69 ms |
8ab11b6+dirty | 1203.23 ms | 1206.02 ms | 2.79 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
488c9c5+dirty | 2.63 MiB | 3.69 MiB | 1.05 MiB |
3aecc61+dirty | 2.36 MiB | 3.12 MiB | 778.58 KiB |
9a3ca65+dirty | 2.36 MiB | 2.82 MiB | 462.89 KiB |
0d3e677+dirty | 2.36 MiB | 3.10 MiB | 753.12 KiB |
63ed251+dirty | 2.36 MiB | 3.10 MiB | 752.55 KiB |
de59d3a+dirty | 2.36 MiB | 3.11 MiB | 760.16 KiB |
c830127+dirty | 2.36 MiB | 3.12 MiB | 778.80 KiB |
700cbf4+dirty | 2.36 MiB | 3.08 MiB | 734.22 KiB |
80b2ce3+dirty | 2.36 MiB | 2.84 MiB | 486.98 KiB |
8ab11b6+dirty | 2.36 MiB | 3.11 MiB | 759.83 KiB |
Previous results on branch: deps/scripts/update-cocoa.sh
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
a9355d1+dirty | 1236.78 ms | 1245.20 ms | 8.43 ms |
9c4a204+dirty | 1231.46 ms | 1239.71 ms | 8.25 ms |
7140a40+dirty | 1208.07 ms | 1211.82 ms | 3.76 ms |
77364bc+dirty | 1241.49 ms | 1236.04 ms | -5.45 ms |
62e1450+dirty | 1219.45 ms | 1236.33 ms | 16.88 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
a9355d1+dirty | 2.36 MiB | 3.12 MiB | 779.40 KiB |
9c4a204+dirty | 2.36 MiB | 3.08 MiB | 735.56 KiB |
7140a40+dirty | 2.36 MiB | 3.10 MiB | 757.94 KiB |
77364bc+dirty | 2.36 MiB | 3.10 MiB | 757.94 KiB |
62e1450+dirty | 2.36 MiB | 3.10 MiB | 755.61 KiB |
iOS (new) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
488c9c5+dirty | 1225.71 ms | 1222.00 ms | -3.71 ms |
3aecc61+dirty | 1240.27 ms | 1240.51 ms | 0.24 ms |
9a3ca65+dirty | 1276.40 ms | 1279.14 ms | 2.74 ms |
0d3e677+dirty | 1239.02 ms | 1241.22 ms | 2.20 ms |
63ed251+dirty | 1223.27 ms | 1222.94 ms | -0.33 ms |
de59d3a+dirty | 1241.17 ms | 1249.16 ms | 8.00 ms |
c830127+dirty | 1225.30 ms | 1229.54 ms | 4.24 ms |
700cbf4+dirty | 1233.96 ms | 1228.27 ms | -5.69 ms |
80b2ce3+dirty | 1245.12 ms | 1262.04 ms | 16.92 ms |
8ab11b6+dirty | 1222.91 ms | 1216.08 ms | -6.83 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
488c9c5+dirty | 3.19 MiB | 4.25 MiB | 1.06 MiB |
3aecc61+dirty | 2.92 MiB | 3.69 MiB | 789.88 KiB |
9a3ca65+dirty | 2.92 MiB | 3.37 MiB | 464.32 KiB |
0d3e677+dirty | 2.92 MiB | 3.66 MiB | 758.42 KiB |
63ed251+dirty | 2.92 MiB | 3.66 MiB | 757.10 KiB |
de59d3a+dirty | 2.92 MiB | 3.67 MiB | 772.59 KiB |
c830127+dirty | 2.92 MiB | 3.69 MiB | 790.17 KiB |
700cbf4+dirty | 2.92 MiB | 3.64 MiB | 740.57 KiB |
80b2ce3+dirty | 2.92 MiB | 3.40 MiB | 492.75 KiB |
8ab11b6+dirty | 2.92 MiB | 3.67 MiB | 772.38 KiB |
Previous results on branch: deps/scripts/update-cocoa.sh
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
a9355d1+dirty | 1231.51 ms | 1239.04 ms | 7.53 ms |
9c4a204+dirty | 1250.62 ms | 1244.24 ms | -6.38 ms |
7140a40+dirty | 1216.93 ms | 1219.32 ms | 2.39 ms |
77364bc+dirty | 1228.46 ms | 1227.37 ms | -1.09 ms |
62e1450+dirty | 1231.73 ms | 1234.63 ms | 2.90 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
a9355d1+dirty | 2.92 MiB | 3.69 MiB | 790.55 KiB |
9c4a204+dirty | 2.92 MiB | 3.64 MiB | 741.21 KiB |
7140a40+dirty | 2.92 MiB | 3.66 MiB | 762.98 KiB |
77364bc+dirty | 2.92 MiB | 3.66 MiB | 762.98 KiB |
62e1450+dirty | 2.92 MiB | 3.66 MiB | 760.67 KiB |
b088cae
to
cb2bf92
Compare
Android (legacy) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
1faf8e3 | 449.18 ms | 432.08 ms | -17.10 ms |
488c9c5 | 461.57 ms | 475.62 ms | 14.05 ms |
76d1baf+dirty | 335.72 ms | 355.52 ms | 19.80 ms |
e22745e | 462.66 ms | 458.10 ms | -4.56 ms |
baa882f | 354.93 ms | 356.18 ms | 1.25 ms |
416f465 | 446.96 ms | 454.22 ms | 7.26 ms |
3261206 | 476.43 ms | 465.96 ms | -10.48 ms |
9cab16b | 463.30 ms | 455.06 ms | -8.24 ms |
b95b8af | 454.05 ms | 454.53 ms | 0.48 ms |
db44eaf | 437.65 ms | 436.06 ms | -1.59 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
1faf8e3 | 17.74 MiB | 20.08 MiB | 2.34 MiB |
488c9c5 | 17.75 MiB | 20.11 MiB | 2.37 MiB |
76d1baf+dirty | 17.73 MiB | 20.04 MiB | 2.31 MiB |
e22745e | 17.74 MiB | 20.08 MiB | 2.34 MiB |
baa882f | 17.73 MiB | 20.06 MiB | 2.33 MiB |
416f465 | 17.74 MiB | 20.09 MiB | 2.35 MiB |
3261206 | 17.75 MiB | 20.11 MiB | 2.37 MiB |
9cab16b | 17.74 MiB | 20.08 MiB | 2.34 MiB |
b95b8af | 17.73 MiB | 20.11 MiB | 2.37 MiB |
db44eaf | 17.74 MiB | 20.08 MiB | 2.35 MiB |
Previous results on branch: deps/scripts/update-cocoa.sh
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
77364bc | 437.12 ms | 434.90 ms | -2.22 ms |
a9355d1 | 488.72 ms | 557.00 ms | 68.28 ms |
62e1450 | 514.67 ms | 496.85 ms | -17.82 ms |
9c4a204 | 439.59 ms | 440.02 ms | 0.43 ms |
7140a40 | 664.39 ms | 656.44 ms | -7.95 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
77364bc | 17.74 MiB | 20.08 MiB | 2.35 MiB |
a9355d1 | 17.74 MiB | 20.10 MiB | 2.36 MiB |
62e1450 | 17.74 MiB | 20.08 MiB | 2.35 MiB |
9c4a204 | 17.74 MiB | 20.08 MiB | 2.34 MiB |
7140a40 | 17.74 MiB | 20.08 MiB | 2.35 MiB |
antonis
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps scripts/update-cocoa.sh from 8.43.0 to 8.44.0.
Auto-generated by a dependency updater.
Changelog
8.44.0
Fixes
sentryReplayUnmask
andsentryReplayUnmask
preventing interaction (#4749)SentryCrashExceptionApplication
implementation for non-macOS target (#4759)NSNull
handling tosentry_sanitize
(#4760)Improvements
cacheDirectoryPath
(#4693)Features
Internal
8.44.0-beta.1
Fixes
Improvements
cacheDirectoryPath
(#4693)Features
Internal
8.43.1-beta.0
Fixes
strncpy
withstrlcpy
(#4636)NSFileManager.createFileAtPath
starting with iOS 18, macOS 15 and tvOS 18. This feature is experimental and must be enabled by setting the optionexperimental.enableFileManagerSwizzling
totrue
(#4634)Internal