-
-
Notifications
You must be signed in to change notification settings - Fork 344
chore(deps): Bumps sample app to RN 0.77.0 #4508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Android (legacy) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
3853f43 | 329.68 ms | 346.32 ms | 16.64 ms |
5fe8312 | 483.51 ms | 485.91 ms | 2.40 ms |
cdf2f33 | 469.46 ms | 462.17 ms | -7.29 ms |
1faf8e3 | 449.18 ms | 432.08 ms | -17.10 ms |
9433f35 | 347.64 ms | 356.22 ms | 8.58 ms |
9282172 | 486.12 ms | 467.70 ms | -18.42 ms |
5446992 | 403.40 ms | 426.70 ms | 23.30 ms |
d197b5c+dirty | 338.94 ms | 354.87 ms | 15.93 ms |
acadc0f+dirty | 373.24 ms | 381.51 ms | 8.27 ms |
ad6c299 | 375.94 ms | 382.02 ms | 6.08 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
3853f43 | 17.73 MiB | 19.81 MiB | 2.08 MiB |
5fe8312 | 17.75 MiB | 20.11 MiB | 2.36 MiB |
cdf2f33 | 17.74 MiB | 20.08 MiB | 2.34 MiB |
1faf8e3 | 17.74 MiB | 20.08 MiB | 2.34 MiB |
9433f35 | 17.73 MiB | 19.81 MiB | 2.08 MiB |
9282172 | 17.74 MiB | 20.09 MiB | 2.35 MiB |
5446992 | 17.73 MiB | 19.85 MiB | 2.12 MiB |
d197b5c+dirty | 17.73 MiB | 20.04 MiB | 2.31 MiB |
acadc0f+dirty | 17.73 MiB | 19.75 MiB | 2.01 MiB |
ad6c299 | 17.73 MiB | 19.75 MiB | 2.02 MiB |
Android (new) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
52c0562+dirty | 401.23 ms | 435.65 ms | 34.42 ms |
e73f4ed+dirty | 262.98 ms | 311.02 ms | 48.04 ms |
a989877+dirty | 383.04 ms | 400.92 ms | 17.88 ms |
63ed251+dirty | 485.02 ms | 531.16 ms | 46.14 ms |
0db0c72+dirty | 335.20 ms | 351.06 ms | 15.86 ms |
ed3d77e+dirty | 366.04 ms | 411.33 ms | 45.28 ms |
ae7b03d+dirty | 403.26 ms | 456.78 ms | 53.52 ms |
e22745e+dirty | 415.50 ms | 448.76 ms | 33.26 ms |
70e6261+dirty | 395.08 ms | 408.12 ms | 13.04 ms |
ddc0552+dirty | 405.80 ms | 480.00 ms | 74.20 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
52c0562+dirty | 7.15 MiB | 8.39 MiB | 1.24 MiB |
e73f4ed+dirty | 7.15 MiB | 8.09 MiB | 965.94 KiB |
a989877+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
63ed251+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
0db0c72+dirty | 7.15 MiB | 8.04 MiB | 911.02 KiB |
ed3d77e+dirty | 7.15 MiB | 8.35 MiB | 1.21 MiB |
ae7b03d+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
e22745e+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
70e6261+dirty | 7.15 MiB | 8.21 MiB | 1.07 MiB |
ddc0552+dirty | 7.15 MiB | 8.37 MiB | 1.22 MiB |
iOS (new) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
0677344+dirty | 1252.52 ms | 1254.08 ms | 1.56 ms |
5f03ae9+dirty | 1237.79 ms | 1241.02 ms | 3.23 ms |
5571a20+dirty | 1228.09 ms | 1233.45 ms | 5.36 ms |
db44eaf+dirty | 1238.49 ms | 1236.56 ms | -1.93 ms |
e4d9fe0+dirty | 1210.45 ms | 1204.23 ms | -6.21 ms |
c639edf+dirty | 1223.63 ms | 1227.98 ms | 4.35 ms |
5446992+dirty | 1249.94 ms | 1254.80 ms | 4.86 ms |
8ab11b6+dirty | 1222.91 ms | 1216.08 ms | -6.83 ms |
1c9e040+dirty | 1214.84 ms | 1222.06 ms | 7.22 ms |
ed3d77e+dirty | 1246.19 ms | 1244.00 ms | -2.19 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
0677344+dirty | 2.92 MiB | 3.41 MiB | 500.94 KiB |
5f03ae9+dirty | 3.19 MiB | 4.25 MiB | 1.06 MiB |
5571a20+dirty | 2.92 MiB | 3.48 MiB | 575.54 KiB |
db44eaf+dirty | 2.92 MiB | 3.66 MiB | 761.15 KiB |
e4d9fe0+dirty | 3.19 MiB | 4.26 MiB | 1.08 MiB |
c639edf+dirty | 2.92 MiB | 3.64 MiB | 742.55 KiB |
5446992+dirty | 2.92 MiB | 3.44 MiB | 535.26 KiB |
8ab11b6+dirty | 2.92 MiB | 3.67 MiB | 772.38 KiB |
1c9e040+dirty | 3.19 MiB | 4.25 MiB | 1.07 MiB |
ed3d77e+dirty | 2.92 MiB | 3.66 MiB | 758.57 KiB |
iOS (legacy) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
0677344+dirty | 1276.70 ms | 1300.07 ms | 23.37 ms |
5f03ae9+dirty | 1232.29 ms | 1230.92 ms | -1.37 ms |
5571a20+dirty | 1203.57 ms | 1204.57 ms | 1.00 ms |
db44eaf+dirty | 1227.09 ms | 1230.65 ms | 3.56 ms |
e4d9fe0+dirty | 1221.43 ms | 1238.51 ms | 17.08 ms |
c639edf+dirty | 1236.18 ms | 1235.04 ms | -1.14 ms |
5446992+dirty | 1273.28 ms | 1276.68 ms | 3.40 ms |
8ab11b6+dirty | 1203.23 ms | 1206.02 ms | 2.79 ms |
1c9e040+dirty | 1226.02 ms | 1221.06 ms | -4.96 ms |
ed3d77e+dirty | 1214.61 ms | 1205.83 ms | -8.78 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
0677344+dirty | 2.36 MiB | 2.85 MiB | 496.81 KiB |
5f03ae9+dirty | 2.63 MiB | 3.68 MiB | 1.05 MiB |
5571a20+dirty | 2.36 MiB | 2.92 MiB | 569.93 KiB |
db44eaf+dirty | 2.36 MiB | 3.10 MiB | 755.81 KiB |
e4d9fe0+dirty | 2.63 MiB | 3.70 MiB | 1.06 MiB |
c639edf+dirty | 2.36 MiB | 3.08 MiB | 736.63 KiB |
5446992+dirty | 2.36 MiB | 2.88 MiB | 531.94 KiB |
8ab11b6+dirty | 2.36 MiB | 3.11 MiB | 759.83 KiB |
1c9e040+dirty | 2.63 MiB | 3.69 MiB | 1.06 MiB |
ed3d77e+dirty | 2.36 MiB | 3.10 MiB | 753.32 KiB |
It there an issue in the react-native-screens library we can follow? https://github.com/software-mansion/react-native-screens?rgh-link-date=2025-02-05T10%3A40%3A13Z This link doesn't seem to work. |
"babel-plugin-module-resolver": "^5.0.0", | ||
"eslint": "^8.19.0", | ||
"eslint-plugin-ft-flow": "^3.0.11", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this devDependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a lint error pointing to this dependency after the eslint-config
bump
ESLint couldn't find the plugin "eslint-plugin-ft-flow".
(The package "eslint-plugin-ft-flow" was not found when loaded as a Node module from the directory "/home/runner/work/sentry-react-native/sentry-react-native/samples/react-native".)
It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:
npm install eslint-plugin-ft-flow@latest --save-dev
The plugin "eslint-plugin-ft-flow" was referenced from the config file in ".eslintrc.js » @react-native/eslint-config#overrides[0]".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 Thank you.
I just have two questions, no blockers.
Thank you for reviewing @krystofwoldrich 🙇
No, there is no issue on the react-native-screens for this. I'll investigate this further and open an issue with all the data if needed. |
📢 Type of change
📜 Description
Bumps sample app to RN 0.77.0
💡 Motivation and Context
React Native 0.77 Release
Android version 15 support & 16KB page support
💚 How did you test it?
CI,
Manual Android/iOS New/Old Architecture
Stack trace
📝 Checklist
sendDefaultPII
is enabled🔮 Next steps
#skip-changelog