Ref: Use main carrier on useEncodePolyfill #4731

lucas-zimerman · 2025-04-07T15:35:07Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

The SDK recommends using getMainCarrier on Sentry JavaScript V9 at any moment that we try to get __SENTRY__. This PR implements the required logic to use the recommended carrier.

💡 Motivation and Context

Fixes #4730

💚 How did you test it?

Localy on an Android device.

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

#skip-changelog

…heck / removed comment from rnerror handler / removed comment from span / fix test from userInteraction

github-actions · 2025-04-07T16:10:31Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1236.59 ms	1251.28 ms	14.69 ms
Size	3.19 MiB	4.32 MiB	1.13 MiB

Baseline results on branch: v7

Startup times

Revision	Plain	With Sentry	Diff
`9da5c4e`+dirty	1215.41 ms	1226.38 ms	10.97 ms

App size

Revision	Plain	With Sentry	Diff
`9da5c4e`+dirty	3.19 MiB	4.33 MiB	1.14 MiB

github-actions · 2025-04-07T16:13:11Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1213.53 ms	1223.09 ms	9.55 ms
Size	2.63 MiB	3.75 MiB	1.12 MiB

Baseline results on branch: v7

Startup times

Revision	Plain	With Sentry	Diff
`9da5c4e`+dirty	1231.84 ms	1235.49 ms	3.65 ms

App size

Revision	Plain	With Sentry	Diff
`9da5c4e`+dirty	2.63 MiB	3.76 MiB	1.13 MiB

… version on samples and e2e

github-actions · 2025-04-07T19:13:03Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	440.66 ms	445.71 ms	5.05 ms
Size	17.75 MiB	20.15 MiB	2.40 MiB

Baseline results on branch: v7

Startup times

Revision	Plain	With Sentry	Diff
`9da5c4e`	478.08 ms	467.46 ms	-10.63 ms

App size

Revision	Plain	With Sentry	Diff
`9da5c4e`	17.75 MiB	20.16 MiB	2.41 MiB

github-actions · 2025-04-07T19:19:37Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	390.78 ms	377.41 ms	-13.37 ms
Size	7.15 MiB	8.41 MiB	1.26 MiB

Baseline results on branch: v7

Startup times

Revision	Plain	With Sentry	Diff
`9da5c4e`+dirty	399.70 ms	407.34 ms	7.64 ms

App size

Revision	Plain	With Sentry	Diff
`9da5c4e`+dirty	7.15 MiB	8.42 MiB	1.27 MiB

antonis

The changes LGTM and aligned with the previous discussion and the function doc

krystofwoldrich

LGTM 🚀

lucas-zimerman added 29 commits February 14, 2025 14:02

bump SDKs

04b6c06

bump SDKs

0dc4bca

fix build

382fef6

fix tests

33af36c

fix tests

ad6a76c

fix lint errors

15342a2

test ts 5.0

c267f9b

rollback

efea84f

Merge branch 'v7' into lz/bump/jsv9

65a10d5

fix merge conflict with yarn

028dbf9

fix new lint issue

a57459a

sync yarn.lock with V7 branch and install new packages

5de9867

ensure we are using the JS version from the default node resolution

ae65521

update changelog with javascript version bump

bd64169

fix check type (#4587)

39a81c7

add major changes to the SDK

3a4fd4c

fix lint

d8088ad

review check: fix changelog PR number / Fix wrapper incorrect null c…

6f71cda

…heck / removed comment from rnerror handler / removed comment from span / fix test from userInteraction

fix incorrect cli version

55c1961

fix lint

97853c6

Merge branch 'v7' into lz/bump/jsv9

dc2e123

remove shutdowntimeout from android / use newer wizard version

9a0b21e

rollback feedback test change, rollback jest version, fix safe test

45ee6fa

return shutdowntimeout

816b506

explain tracing sample rate

25bf147

fix tracing extension test

8584214

Merge branch 'v7' into lz/bump/jsv9

a26497e

lint fix

499e5a3

update changelog

578ad2c

lucas-zimerman added 4 commits April 7, 2025 13:14

merge v7

d7fe6c6

fix yarn lock merge/ fix ts-jest version no longer exists / fix core…

b08c54f

… version on samples and e2e

fix lint on addTimeToInitialDisplay

19197f3

fix issue with UIManager test

709697c

lucas-zimerman marked this pull request as ready for review April 7, 2025 18:59

lucas-zimerman requested review from krystofwoldrich and antonis as code owners April 7, 2025 18:59

lucas-zimerman added 4 commits April 7, 2025 16:32

use main carrier

4538bce

fix yarn lint

a64450d

moved major changes to the correct spot

a5ddcda

Merge branch 'lz/bump/jsv9' into lz/jsv9/carrier

6d86583

antonis approved these changes Apr 8, 2025

View reviewed changes

krystofwoldrich approved these changes Apr 9, 2025

View reviewed changes

Base automatically changed from lz/bump/jsv9 to v7 April 15, 2025 08:26

Merge branch 'v7' into lz/jsv9/carrier

4764570

lucas-zimerman merged commit 99b2852 into v7 Apr 15, 2025
64 checks passed

lucas-zimerman deleted the lz/jsv9/carrier branch April 15, 2025 16:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ref: Use main carrier on useEncodePolyfill #4731

Ref: Use main carrier on useEncodePolyfill #4731

lucas-zimerman commented Apr 7, 2025 •

edited

Loading

github-actions bot commented Apr 7, 2025 •

edited

Loading

Baseline results on branch: v7

Startup times

App size

github-actions bot commented Apr 7, 2025 •

edited

Loading

Baseline results on branch: v7

Startup times

App size

github-actions bot commented Apr 7, 2025 •

edited

Loading

Baseline results on branch: v7

Startup times

App size

github-actions bot commented Apr 7, 2025 •

edited

Loading

Baseline results on branch: v7

Startup times

App size

antonis left a comment

krystofwoldrich left a comment

Ref: Use main carrier on useEncodePolyfill #4731

Ref: Use main carrier on useEncodePolyfill #4731

Conversation

lucas-zimerman commented Apr 7, 2025 • edited Loading

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

github-actions bot commented Apr 7, 2025 • edited Loading

iOS (new) Performance metrics 🚀

Baseline results on branch: v7

Startup times

App size

github-actions bot commented Apr 7, 2025 • edited Loading

iOS (legacy) Performance metrics 🚀

Baseline results on branch: v7

Startup times

App size

github-actions bot commented Apr 7, 2025 • edited Loading

Android (legacy) Performance metrics 🚀

Baseline results on branch: v7

Startup times

App size

github-actions bot commented Apr 7, 2025 • edited Loading

Android (new) Performance metrics 🚀

Baseline results on branch: v7

Startup times

App size

antonis left a comment

Choose a reason for hiding this comment

krystofwoldrich left a comment

Choose a reason for hiding this comment

lucas-zimerman commented Apr 7, 2025 •

edited

Loading

github-actions bot commented Apr 7, 2025 •

edited

Loading

github-actions bot commented Apr 7, 2025 •

edited

Loading

github-actions bot commented Apr 7, 2025 •

edited

Loading

github-actions bot commented Apr 7, 2025 •

edited

Loading