Fix: V7 - JavaScript V9 - set undefined for updateProd when not set #4740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…heck / removed comment from rnerror handler / removed comment from span / fix test from userInteraction
packages/core/src/js/sdk.tsx
Outdated
| updateProps: {} | ||
| updateProps: options?.profilerProps |
There was a problem hiding this comment.
I thought we would keep the updateProps: {}? I think just removing the updateProps from the wrap type and here ensuring they will always be {} is enough. I would not delete them in the ReactNativeProfiler class.
There was a problem hiding this comment.
Sorry, probably a misunderstanding, fixed here 517161c
|
@krystofwoldrich I had to split the mocked and real tests from the wrap due to internal conflicts with the internal libraries when interacting with both on the same file (I can't properly remove the mocks otherwise it breaks the React Native testing hooks). |
Co-authored-by: Krystof Woldrich <[email protected]>
krystofwoldrich
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
updatePropsalways set but with undefined value, avoiding break changes and making the compiler happy.updatePropsandchildrenfrom wrap options.💡 Motivation and Context
Fixes: #4728
💚 How did you test it?
Unit test, Sample app
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps
#skip-changelog.