Skip to content

chore(ci): Fixes iOS binary size diff failure #4817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2025
Merged

chore(ci): Fixes iOS binary size diff failure #4817

merged 1 commit into from
May 8, 2025

Conversation

antonis
Copy link
Collaborator

@antonis antonis commented May 7, 2025 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Increase iOS binary size diff by 100KB (to 1300 KB) to avoid failing binary size checks.

💡 Motivation and Context

I've noticed that metrics (new, ios) check has started to fail consistently onmain after bumping the iOS SDK.

BinarySizeTest > app size() FAILED
    java.lang.AssertionError: 1229276 should be < 1228800
        at BinarySizeTest.app size(BinarySizeTest.kt:37)

Notes:

💚 How did you test it?

CI

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 7, 2025

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 400.00 ms 394.10 ms -5.90 ms
Size 17.75 MiB 20.13 MiB 2.38 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
7fd512a 442.18 ms 437.57 ms -4.61 ms
3261206 476.43 ms 465.96 ms -10.48 ms
5bb8d5f 431.21 ms 459.40 ms 28.19 ms
c398f67 449.64 ms 461.38 ms 11.74 ms
1d86dd6 405.14 ms 411.06 ms 5.92 ms
0db0c72 372.12 ms 386.00 ms 13.88 ms
bd0ca38 418.14 ms 425.96 ms 7.82 ms
52a8031+dirty 311.55 ms 321.37 ms 9.82 ms
a18210a 455.15 ms 530.29 ms 75.15 ms
b6f8ea2 472.49 ms 469.60 ms -2.89 ms

App size

Revision Plain With Sentry Diff
7fd512a 17.74 MiB 20.08 MiB 2.35 MiB
3261206 17.75 MiB 20.11 MiB 2.37 MiB
5bb8d5f 17.73 MiB 19.93 MiB 2.20 MiB
c398f67 17.73 MiB 19.94 MiB 2.21 MiB
1d86dd6 17.73 MiB 19.86 MiB 2.12 MiB
0db0c72 17.73 MiB 19.75 MiB 2.02 MiB
bd0ca38 17.75 MiB 20.13 MiB 2.38 MiB
52a8031+dirty 17.73 MiB 20.04 MiB 2.31 MiB
a18210a 17.75 MiB 20.11 MiB 2.36 MiB
b6f8ea2 17.75 MiB 20.11 MiB 2.36 MiB

Previous results on branch: antonis/ci-ios-binary-size

Startup times

Revision Plain With Sentry Diff
a202c7a 495.10 ms 494.98 ms -0.13 ms
90ec215 422.56 ms 422.70 ms 0.14 ms
1a94d77 342.82 ms 335.92 ms -6.90 ms

App size

Revision Plain With Sentry Diff
a202c7a 17.75 MiB 20.11 MiB 2.37 MiB
90ec215 17.75 MiB 20.15 MiB 2.40 MiB
1a94d77 17.75 MiB 20.11 MiB 2.37 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 7, 2025

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 421.60 ms 441.74 ms 20.14 ms
Size 7.15 MiB 8.40 MiB 1.25 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d16beca+dirty 389.49 ms 423.86 ms 34.37 ms
e652a2e+dirty 368.83 ms 360.91 ms -7.91 ms
5852d77+dirty 378.83 ms 381.89 ms 3.06 ms
abb7058+dirty 320.78 ms 324.08 ms 3.30 ms
950b04f+dirty 308.66 ms 312.69 ms 4.03 ms
1c65324+dirty 381.10 ms 427.26 ms 46.16 ms
cc8a6ca+dirty 397.63 ms 393.60 ms -4.03 ms
cdc3945+dirty 428.13 ms 443.92 ms 15.78 ms
1d7ae00+dirty 373.63 ms 417.21 ms 43.58 ms
79976dd+dirty 373.25 ms 404.64 ms 31.39 ms

App size

Revision Plain With Sentry Diff
d16beca+dirty 7.15 MiB 8.37 MiB 1.22 MiB
e652a2e+dirty 7.15 MiB 8.38 MiB 1.23 MiB
5852d77+dirty 7.15 MiB 8.38 MiB 1.22 MiB
abb7058+dirty 7.15 MiB 8.10 MiB 980.40 KiB
950b04f+dirty 7.15 MiB 8.40 MiB 1.25 MiB
1c65324+dirty 7.15 MiB 8.22 MiB 1.07 MiB
cc8a6ca+dirty 7.15 MiB 8.39 MiB 1.23 MiB
cdc3945+dirty 7.15 MiB 8.39 MiB 1.23 MiB
1d7ae00+dirty 7.15 MiB 8.39 MiB 1.23 MiB
79976dd+dirty 7.15 MiB 8.38 MiB 1.23 MiB

Previous results on branch: antonis/ci-ios-binary-size

Startup times

Revision Plain With Sentry Diff
a202c7a+dirty 398.12 ms 447.65 ms 49.53 ms
90ec215+dirty 659.49 ms 692.31 ms 32.82 ms
1a94d77+dirty 469.30 ms 614.86 ms 145.56 ms

App size

Revision Plain With Sentry Diff
a202c7a+dirty 7.15 MiB 8.38 MiB 1.23 MiB
90ec215+dirty 7.15 MiB 8.42 MiB 1.26 MiB
1a94d77+dirty 7.15 MiB 8.38 MiB 1.23 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 7, 2025

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1222.86 ms 1222.69 ms -0.16 ms
Size 2.63 MiB 3.79 MiB 1.16 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
575f9da+dirty 1266.22 ms 1274.84 ms 8.62 ms
94fc925+dirty 1231.12 ms 1223.85 ms -7.27 ms
7d161c0+dirty 1215.20 ms 1218.64 ms 3.43 ms
17c0c2e+dirty 1231.45 ms 1235.10 ms 3.66 ms
e8e44ed+dirty 1220.44 ms 1216.42 ms -4.02 ms
e1e6bc7+dirty 1208.24 ms 1221.46 ms 13.22 ms
f8fa2ad+dirty 1239.08 ms 1235.49 ms -3.59 ms
af2c0b0+dirty 1201.83 ms 1208.94 ms 7.11 ms
2501f36+dirty 1232.17 ms 1232.50 ms 0.33 ms
1c65324+dirty 1235.17 ms 1235.08 ms -0.09 ms

App size

Revision Plain With Sentry Diff
575f9da+dirty 2.36 MiB 2.87 MiB 520.20 KiB
94fc925+dirty 2.63 MiB 3.69 MiB 1.05 MiB
7d161c0+dirty 2.63 MiB 3.75 MiB 1.12 MiB
17c0c2e+dirty 2.63 MiB 3.78 MiB 1.14 MiB
e8e44ed+dirty 2.63 MiB 3.76 MiB 1.13 MiB
e1e6bc7+dirty 2.63 MiB 3.78 MiB 1.15 MiB
f8fa2ad+dirty 2.63 MiB 3.78 MiB 1.14 MiB
af2c0b0+dirty 2.63 MiB 3.76 MiB 1.13 MiB
2501f36+dirty 2.63 MiB 3.76 MiB 1.13 MiB
1c65324+dirty 2.36 MiB 3.04 MiB 698.64 KiB

Previous results on branch: antonis/ci-ios-binary-size

Startup times

Revision Plain With Sentry Diff
1a94d77+dirty 1219.10 ms 1217.38 ms -1.72 ms
90ec215+dirty 1221.18 ms 1222.32 ms 1.14 ms
a202c7a+dirty 1229.63 ms 1230.33 ms 0.71 ms

App size

Revision Plain With Sentry Diff
1a94d77+dirty 2.63 MiB 3.69 MiB 1.06 MiB
90ec215+dirty 2.63 MiB 3.80 MiB 1.17 MiB
a202c7a+dirty 2.63 MiB 3.69 MiB 1.05 MiB

@antonis antonis marked this pull request as ready for review May 7, 2025 11:25
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 7, 2025

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1219.12 ms 1221.65 ms 2.53 ms
Size 3.19 MiB 4.36 MiB 1.17 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
575f9da+dirty 1272.00 ms 1284.38 ms 12.38 ms
94fc925+dirty 1231.04 ms 1231.60 ms 0.55 ms
7d161c0+dirty 1239.57 ms 1250.46 ms 10.89 ms
17c0c2e+dirty 1239.76 ms 1243.32 ms 3.56 ms
e8e44ed+dirty 1222.90 ms 1219.75 ms -3.15 ms
e1e6bc7+dirty 1221.47 ms 1237.02 ms 15.55 ms
f8fa2ad+dirty 1227.51 ms 1212.89 ms -14.62 ms
af2c0b0+dirty 1229.82 ms 1231.41 ms 1.59 ms
2501f36+dirty 1232.98 ms 1227.81 ms -5.17 ms
1c65324+dirty 1239.71 ms 1239.86 ms 0.15 ms

App size

Revision Plain With Sentry Diff
575f9da+dirty 2.92 MiB 3.43 MiB 524.26 KiB
94fc925+dirty 3.19 MiB 4.25 MiB 1.07 MiB
7d161c0+dirty 3.19 MiB 4.32 MiB 1.13 MiB
17c0c2e+dirty 3.19 MiB 4.34 MiB 1.16 MiB
e8e44ed+dirty 3.19 MiB 4.33 MiB 1.14 MiB
e1e6bc7+dirty 3.19 MiB 4.35 MiB 1.16 MiB
f8fa2ad+dirty 3.19 MiB 4.35 MiB 1.16 MiB
af2c0b0+dirty 3.19 MiB 4.33 MiB 1.14 MiB
2501f36+dirty 3.19 MiB 4.33 MiB 1.14 MiB
1c65324+dirty 2.92 MiB 3.61 MiB 705.56 KiB

Previous results on branch: antonis/ci-ios-binary-size

Startup times

Revision Plain With Sentry Diff
1a94d77+dirty 1222.51 ms 1230.16 ms 7.65 ms
90ec215+dirty 1220.78 ms 1226.56 ms 5.78 ms
a202c7a+dirty 1218.98 ms 1215.89 ms -3.09 ms

App size

Revision Plain With Sentry Diff
1a94d77+dirty 3.19 MiB 4.25 MiB 1.07 MiB
90ec215+dirty 3.19 MiB 4.37 MiB 1.18 MiB
a202c7a+dirty 3.19 MiB 4.25 MiB 1.07 MiB

@antonis antonis mentioned this pull request May 7, 2025
Merged
8 tasks
lucas-zimerman
lucas-zimerman approved these changes May 7, 2025
View reviewed changes
Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe in the future we'll need a different approach for this test if test size keeps increasing over time.
but for now, LGTM!

@antonis
Copy link
Collaborator Author

antonis commented May 8, 2025 •
edited
Loading

Maybe in the future we'll need a different approach for this test if test size keeps increasing over time

I agree 🤔

Proceeding with merge since the 100kb bump (to 1300kb) has already landed on the Feedback Widget feature branch and main is 🔴

@antonis antonis merged commit 1d75738 into main May 8, 2025
106 of 108 checks passed
@antonis antonis deleted the antonis/ci-ios-binary-size branch May 8, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-zimerman lucas-zimerman lucas-zimerman approved these changes

@krystofwoldrich krystofwoldrich Awaiting requested review from krystofwoldrich krystofwoldrich is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonis @lucas-zimerman