Add option to enable propagation of parent span tags

[DoumanAsh]

I would like to suggest option to allow event's spans to automatically insert first available tag as tag within event, rather than propagating it as additional data

Old behavior can be used together with this feature too

But I often find it inconvenient that events may not contain tags from within span (especially if spans get rate limited at sentry)
What do you think about this addition?
Let me know if you'd like me to make some adjustments to PR

[lcian]

Hi @DoumanAsh , thanks for the PR and sorry for the wait here!
Could you please provide an example that shows the difference in behavior with SpanPropagation::Attributes and SpanPropagation::All?

[DoumanAsh]

Would test case suffice or what sort of example you'd like to see?

[DoumanAsh]

Actually I kinda forgot about it, but looking back at implementation, event stores fields in context Rust Tracing Fields
Would it be able to store tags at all...

I also see that iterator over data does not include tags... so this PR is incorrect
I'm sorry I will have to re-work it

[lcian]

No problem.
I would like to see an example using top level APIs of sentry-rust/tracing and how the result is different in the envelope/UI.
I tried some stuff for myself combining the span/message APIs of both and using both attributes and tags in my spans but I was never able to hit this code path: https://github.com/DoumanAsh/sentry-rust/blob/7344609dcbfee4c9d855a72ad28a40ecda390d5c/sentry-tracing/src/converters.rs#L111C1-L115C18

I don't clearly see how, but maybe this might be affected by 3bcdda3
In that commit we've changed transaction.data() and transaction.set_data() to operate on the trace context instead of extra (which is correct from the point of view of SDKs)

[DoumanAsh]

@lcian Actually I know what is problem is and it is very trivial mistake on my part
But my PC is broken right now so I will try to get to it as soon as I can to get this PR working and will add test to showcase tags

[lcian]

@lcian Actually I know what is problem is and it is very trivial mistake on my part But my PC is broken right now so I will try to get to it as soon as I can to get this PR working and will add test to showcase tags

Nice, thanks!

[DoumanAsh]

@lcian I refactored my code to correctly look up span's tags on new event (this of course not possible for breadcrumbs, but events/exceptions should be working as it carries tags)
https://github.com/DoumanAsh/sentry-rust/blob/span_propagate_tags/sentry-tracing/tests/smoke.rs#L22

[lcian]

I think this makes sense, thanks.
Could we pass SpanPropagation as an additional parameter to the functions instead of passing it around in the tuple with Context?

[DoumanAsh]

It is kinda not really used without context so I made it together
But if you prefer it separately sure

[DoumanAsh]

Rebased and refactored context passing
0e59852

[lcian]

Thank you, will take a look soon!