Improve release default value #325
Conversation
| @@ -111,7 +112,7 @@ public function getConfigTreeBuilder(): TreeBuilder | |||
| ->prototype('scalar'); | |||
| $optionsChildNodes->scalarNode('project_root'); | |||
| $optionsChildNodes->scalarNode('release') | |||
| ->defaultValue(Versions::getVersion(Versions::ROOT_PACKAGE_NAME)) | |||
| ->defaultValue(PrettyVersions::getVersion(Versions::ROOT_PACKAGE_NAME)->getPrettyVersion()) | |||
There was a problem hiding this comment.
Is this still going to lead to trackable hashes in sentry? The previous version kinda did
There was a problem hiding this comment.
This is the behavior, from the readme:
if the requested package is a tagged version, it will return just the short version; if not, [...] it will return the version of the package, followed by the short version of the commit hash (i.e.
6.0.0@fa5711)
[EDIT] The short version is just the tag.
So, it should.
There was a problem hiding this comment.
@Jean85 most software is released via rolling master or such directly, so it will likely be dev-master@abcdef
If sentry can work with that, we should be OK, just wanted to make sure of that.
| @@ -21,7 +21,6 @@ | |||
| "require": { | |||
| "php": "^7.1", | |||
| "jean85/pretty-package-versions": "^1.0", | |||
| "ocramius/package-versions": "^1.3.0", | |||
There was a problem hiding this comment.
This removal seems wrong, as the code is still depending directly on \PackageVersions\Versions::ROOT_PACKAGE_NAME in src/DependencyInjection/Configuration.php
There was a problem hiding this comment.
That's right, a composer-checker run would have spotted that. BTW this will not break the app since that is an implicit dependency of jean85/pretty-package-versions.
Fixes #323, improves upon #292.
Since PrettyVersion is already a requirement of this bundle, we can use it directly to obtain a prettier release tag from the project.
Note: this will still not work if the
.gitfolder is missing.