Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace sentry/sdk by sentry/sentry 3.17 #718

Closed

Conversation

nicolas-grekas
Copy link

Same as #693, but updated to 3.17 thanks to getsentry/sentry-php#1504

@cleptric
Copy link
Member

cleptric commented May 3, 2023

Holding off on this for the moment. We don't need to fix what is not broken.
We'll revisit this in the next major of the base SDK.

To go into more detail, I'm not fond of removing dependencies from users' installations and now relying upon that https://github.com/php-http/discovery is properly configured on their end.
This might cause interruptions I'm currently unwilling to offload to our users.

@nicolas-grekas
Copy link
Author

nicolas-grekas commented May 3, 2023

The thing that is "broken" is sentry/sdk, which forces a specific client implementation, whereas php-http/discovery already does the job. It's super weird that the recommended solution is to "replace" the SDK.

Linking to #246 for reference.

@nicolas-grekas
Copy link
Author

Even the README of this package suggests the "replace". This is something that's solved now, let's clear this up 🙏

@cleptric
Copy link
Member

cleptric commented May 3, 2023

The thing that is "broken" is sentry/sdk, which forces a specific client implementation, whereas php-http/discovery already does the job.

We already ran into many issues due to php-http/discovery, and right now, I stand by my decision to postpone any further changes in this regard until the next major version.

This is again in strong alignment with our SDK philosophy: https://develop.sentry.dev/sdk/philosophy/#degrade-gracefully.

I wasn't aware of the mentioned passage in our README, I can take a look if this still applies.

@cleptric cleptric closed this May 8, 2023
@nicolas-grekas nicolas-grekas deleted the auto-discovery branch May 8, 2023 11:35
@nicolas-grekas
Copy link
Author

nicolas-grekas commented May 8, 2023

Let's go for a v2v5?

@cleptric
Copy link
Member

cleptric commented May 8, 2023

v4 of https://github.com/getsentry/sentry-php 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants