Add opt-in screenshot attachment for crash events captured on Windows/Linux#582
Add opt-in screenshot attachment for crash events captured on Windows/Linux#582tustanivsky merged 11 commits intomainfrom
Conversation
|
plugin-dev/Source/Sentry/Private/Desktop/SentrySubsystemDesktop.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Changes like this reeeally make me think we should put a linter in the repo.
There was a problem hiding this comment.
We'll probably cover this in scope of #575
Co-authored-by: Stefan Jandl <reg@bitfox.at>
# Conflicts: # CHANGELOG.md
bitsandfoxes
left a comment
bitsandfoxes
left a comment
There was a problem hiding this comment.
Just to double check: In case the screenshot capture fails to write the file to disk, does the crashhandler deal with it gracefully?
If a screenshot can't be captured for some reason crashpad will simply ignore that and capture crash as usual without adding a corresponding attachment. At the same time logs should contain info about screenshot capturing failure reason. |
|
Is this on the docs? Couldn't find any reference to screenshots there |
3 participants
Related to #567