feat(spans-migration): add warning UI for dropped fields. #101364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| }) | ||
| ) | ||
| ); | ||
| } |
There was a problem hiding this comment.
Bug: Array Handling Issue in Warning Messages
The reason field for dropped equations and orderby clauses is typed as string | string[]. When this field is an array, it displays incorrectly in warning messages.
Additional Locations (1)
| sessionDurationWarning, | ||
| spanTimeRangeWarning, | ||
| transactionsDeprecationWarning, | ||
| droppedColumnsWarning, |
There was a problem hiding this comment.
Bug: Type Mismatch in Warnings Array
The warnings array is cast as string[], but droppedColumnsWarning (and transactionsDeprecationWarning) return React.JSX.Element | null. This type mismatch could cause runtime issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we've returned the
changedReasoncolumn from the widget and saved query apis we're creating the UI for these dropped fields warnings. This is an example of what they look like:Explore:
Widgets:
