feat(eap): Sets up double deletion of occurrences with EAP #101385
+230
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
shashjar
commented
Oct 10, 2025
|
|
||
| # Enables deletion from EAP for a set of projects | ||
| register( | ||
| "eventstream.eap.deletion_enabled.project_allowlist", |
There was a problem hiding this comment.
Does a project allowlist fit with how we want to do initial rollout/testing?
shashjar
commented
Oct 10, 2025
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| def delete_groups_from_eap_rpc( |
There was a problem hiding this comment.
Would like opinions on how to organize this code, e.g. in a separate file as drafted or alongside the Snuba eventstream impl
shashjar
commented
Oct 10, 2025
| and_filter=AndFilter(filters=[project_filter, group_id_filter]) | ||
| ) | ||
| filter_with_type = TraceItemFilterWithType( | ||
| item_type=TRACE_ITEM_TYPE_OCCURRENCE, |
There was a problem hiding this comment.
I'm unclear why we have both TRACE_ITEM_TYPE_OCCURRENCE & TRACE_ITEM_TYPE_ERROR. I thought we were using "occurrences" as the term for all error events stored in EAP?
shashjar
commented
Oct 10, 2025
| from sentry.testutils.cases import TestCase | ||
|
|
||
|
|
||
| class TestEAPDeletion(TestCase): |
There was a problem hiding this comment.
Basic tests for now, to be improved later
shashjar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets up double deletion of occurrences with EAP, as described in ID-997.
When deleting events from eventstore, we should also delete from EAP using the in-progress
DeleteTraceItemsendpoint (protobuf definition).