ref(dashboards): Remove DashboardTombstone model#114265
Merged
gggritso merged 2 commits intoApr 29, 2026
Merged
Conversation
Remove the DashboardTombstone model class and all code references. The model tracked which pre-built dashboards were deleted for an org, but no production code references it anymore. The database table is left in place — a follow-up migration will move it to pending deletion, and a final migration will drop it. Refs DAIN-1567 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Backend
This was referenced Apr 29, 2026
CI requires the migration to ship alongside the model removal. Drop the FK constraint and move to pending deletion state — the table stays in PostgreSQL for rolling deploy safety. Refs DAIN-1567 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
This PR has a migration; here is the generated SQL for for --
-- Alter field organization on dashboardtombstone
--
SET CONSTRAINTS "sentry_dashboardtomb_organization_id_fa5fbf63_fk_sentry_or" IMMEDIATE; ALTER TABLE "sentry_dashboardtombstone" DROP CONSTRAINT "sentry_dashboardtomb_organization_id_fa5fbf63_fk_sentry_or";
--
-- Moved model DashboardTombstone to pending deletion state
--
-- (no-op) |
wedamija
approved these changes
Apr 29, 2026
gggritso
deleted the
georgegritsouk/dain-1567-remove-dashboardtombstone-model
branch
gggritso
added a commit
that referenced
this pull request
Apr 30, 2026
Drop the `sentry_dashboardtombstone` table from PostgreSQL via `SafeDeleteModel(DELETE)`. Do not merge this until #114265 has been deployed and verified in production. ## PR Stack 1. #114265 — Remove model + `MOVE_TO_PENDING` migration 2. **#114267 ← this PR** — `DELETE` migration to drop the table (deploy after #114265) Refs DAIN-1567 --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
cleptric
pushed a commit
that referenced
this pull request
May 5, 2026
Remove the `DashboardTombstone` model class, all code references, and add the `MOVE_TO_PENDING` migration. `DashboardTombstone` was used to track if users deleted the pre-built "General" dashboard, but that dashboards no longer exists. Pre-built dashboards now use a new system where they're stored in the database as stubs. So, tombstones are no longer needed! Actual deletion in another PR, this just removes the model and the FK constraint. This PR was semi Claude-ed, if someone could give it a close look I'd appreciate it! --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
cleptric
pushed a commit
that referenced
this pull request
May 5, 2026
Drop the `sentry_dashboardtombstone` table from PostgreSQL via `SafeDeleteModel(DELETE)`. Do not merge this until #114265 has been deployed and verified in production. ## PR Stack 1. #114265 — Remove model + `MOVE_TO_PENDING` migration 2. **#114267 ← this PR** — `DELETE` migration to drop the table (deploy after #114265) Refs DAIN-1567 --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the
DashboardTombstonemodel class, all code references, and add theMOVE_TO_PENDINGmigration.DashboardTombstonewas used to track if users deleted the pre-built "General" dashboard, but that dashboards no longer exists. Pre-built dashboards now use a new system where they're stored in the database as stubs. So, tombstones are no longer needed! Actual deletion in another PR, this just removes the model and the FK constraint.This PR was semi Claude-ed, if someone could give it a close look I'd appreciate it!