feat(cmdk): Add settings field search to command palette on settings pages#114274
feat(cmdk): Add settings field search to command palette on settings pages#114274
Conversation
…pages Adds page-scoped CMDK actions that surface individual settings form fields when navigating settings pages. This reuses the existing FormSource data (both the generated FORM_FIELD_REGISTRY and legacy data/forms files) so the command palette can search across all registered settings fields and navigate directly to the matching page with a hash anchor to the field. Actions are grouped by settings page, sorted alphabetically, and only rendered when the user is on org or account settings pages. Refs DE-720
github-actions
Bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0f35347. Configure here.
| } | ||
|
|
||
| export function SettingsCommandPaletteActions() { | ||
| const organization = useOrganization(); |
There was a problem hiding this comment.
Missing allowNull crashes account settings for org-less users
High Severity
SettingsCommandPaletteActions calls useOrganization() without {allowNull: true}, but it's rendered inside AccountSettingsLayout, which is reachable by users who don't belong to any organization. In that scenario, useOrganization() throws, crashing the entire account settings page. Other settings components like settingsIndex.tsx explicitly use allowNull: true with a comment noting that organization may be null for org-less users — and that component redirects those users directly to /settings/account/.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 0f35347. Configure here.
| return ( | ||
| <AnalyticsArea name="organization"> | ||
| <SettingsLayout> | ||
| <SettingsCommandPaletteActions /> |
There was a problem hiding this comment.
since this component is rendered as a shared layout for all /settings pages, shouldn’t we just add it there?
2 participants
Wires up settings search form source to CMDK on settings pages
Refs DE-720