fix(seer): Propagate viewer_context on explorer run polling#114281
Merged
trevor-e merged 1 commit intoApr 29, 2026
Conversation
SeerExplorerClient builds a SeerViewerContext at construction and threads it through start_run, continue_run, get_runs, and push_changes — but the polling path (get_run, and the push_changes PR-creation poll) called fetch_run_status / poll_until_done without passing viewer_context. The explicit context was silently dropped on every poll, causing viewer_context.missing warnings at the seer_rpc_out chokepoint whenever the caller (e.g. a Celery task) had no ambient viewer context set. Add an optional viewer_context kwarg to fetch_run_status and poll_until_done and pass self.viewer_context from the three client callsites, matching the existing pattern in the rest of the client. Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Backend
JoshFerge
approved these changes
Apr 29, 2026
3 tasks
cleptric
pushed a commit
that referenced
this pull request
May 5, 2026
`SeerExplorerClient` builds a `SeerViewerContext` at construction and threads it through `start_run`, `continue_run`, `get_runs`, and `push_changes`. The polling path (`get_run`, and the `push_changes` PR-creation poll) was the odd one out — it called `fetch_run_status` / `poll_until_done` without passing `viewer_context`, so the explicit context was silently dropped on every poll. This caused `viewer_context.missing (point='seer_rpc_out')` warnings whenever the caller (e.g. a Celery task) had no ambient viewer context set, like night-shift triage. Add an optional `viewer_context` kwarg to `fetch_run_status` and `poll_until_done` and pass `self.viewer_context` from the three client callsites, matching the existing pattern in the rest of the client. Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SeerExplorerClientbuilds aSeerViewerContextat construction andthreads it through
start_run,continue_run,get_runs, andpush_changes. The polling path (get_run, and thepush_changesPR-creation poll) was the odd one out — it called
fetch_run_status/poll_until_donewithout passingviewer_context, so the explicitcontext was silently dropped on every poll. This caused
viewer_context.missing (point='seer_rpc_out')warnings whenever thecaller (e.g. a Celery task) had no ambient viewer context set, like
night-shift triage.
Add an optional
viewer_contextkwarg tofetch_run_statusandpoll_until_doneand passself.viewer_contextfrom the three clientcallsites, matching the existing pattern in the rest of the client.