fix(legal): Prevent stored XSS via javascript: URLs in policy revision flow#114283
Merged
Conversation
…n flow
The legal/compliance policy row rendered policy URLs in two unsafe ways: the "Review" LinkButton used the raw `policy.url` string directly as an href, and the `showPolicy` popup handler also passed the raw URL to `window.open`. Because `new URL('javascript:...')` parses successfully, `safeURL` returned a truthy URL object for javascript: scheme values, allowing the outer `policy.url && policyUrl` guard to pass. Any billing user who clicked "Review" on an affected policy would execute arbitrary JavaScript in the current page's context.
Fixes: - Add an explicit http/https protocol allowlist check after `safeURL` so that javascript:, data:, and other dangerous schemes are treated as invalid and produce a null `policyUrl`. - Replace `policy.url` with `policyUrl.toString()` in the "Review" LinkButton and `showPolicy` so all three rendering paths (iframe src, window.open, and anchor href) go through the validated reference. - Add a `validate` function to `PolicyRevisionSchema`'s url field in the admin form so non-http(s) URLs are rejected at submission time, preventing malicious values from being stored in the first place.
github-actions
Bot
added
the
Scope: Frontend
swartzrock
changed the title
dashed
approved these changes
May 4, 2026
cleptric
pushed a commit
that referenced
this pull request
May 5, 2026
…n flow (#114283) The legal/compliance policy row rendered policy URLs in two unsafe ways: the "Review" LinkButton used the raw `policy.url` string directly as an href, and the `showPolicy` popup handler also passed the raw URL to `window.open`. Because `new URL('javascript:...')` parses successfully, `safeURL` returned a truthy URL object for javascript: scheme values, allowing the outer `policy.url && policyUrl` guard to pass. Any billing user who clicked "Review" on an affected policy would execute arbitrary JavaScript in the current page's context. Fixes: - Add an explicit http/https protocol allowlist check after `safeURL` so that javascript:, data:, and other dangerous schemes are treated as invalid and produce a null `policyUrl`. - Replace `policy.url` with `policyUrl.toString()` in the "Review" LinkButton and `showPolicy` so all three rendering paths (iframe src, window.open, and anchor href) go through the validated reference. - Add a `validate` function to `PolicyRevisionSchema`'s url field in the admin form so non-http(s) URLs are rejected at submission time, preventing malicious values from being stored in the first place. Fixes https://linear.app/getsentry/issue/REVENG-38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The legal/compliance policy row rendered policy URLs in two unsafe ways: the "Review" LinkButton used the raw
policy.urlstring directly as an href, and theshowPolicypopup handler also passed the raw URL towindow.open. Becausenew URL('javascript:...')parses successfully,safeURLreturned a truthy URL object for javascript: scheme values, allowing the outerpolicy.url && policyUrlguard to pass. Any billing user who clicked "Review" on an affected policy would execute arbitrary JavaScript in the current page's context.Fixes: - Add an explicit http/https protocol allowlist check after
safeURLso that javascript:, data:, and other dangerous schemes are treated as invalid and produce a nullpolicyUrl. - Replacepolicy.urlwithpolicyUrl.toString()in the "Review" LinkButton andshowPolicyso all three rendering paths (iframe src, window.open, and anchor href) go through the validated reference. - Add avalidatefunction toPolicyRevisionSchema's url field in the admin form so non-http(s) URLs are rejected at submission time, preventing malicious values from being stored in the first place.Fixes https://linear.app/getsentry/issue/REVENG-38