Conversation
github-actions
bot
added
the
Scope: Frontend
scttcper
approved these changes
Mar 24, 2025
ryan953
deleted the
ryan953/ref-doReleaseHealthRequest-doSessionsRequest
branch
andrewshie-sentry
pushed a commit
that referenced
this pull request
Mar 27, 2025
…`includeAllArgs=true` (#87675) There were a bunch of `any` types in here, and some janky method signatures because both these methods accepted `includeAllArgs:false` to be passed in. Instead of allowing for that flexibility, lets just hard-code `includeAllArgs:true` and simplify all the types along the way. Notice some improvements: - we're returning `ApiResult<...>` instead of manually writing out the tuple - `requestData: any;` and `requester: any;` are gone, meaning we have typesafe params at the site of the method calls - Whatever `requestData.field` is doing, i didn't want to change it too much. `injectedFields.push` seems pointless; but i'm not breaking it. - We can easily unpack the `ApiResult` tuple with `.then(([response]) => {...`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were a bunch of
anytypes in here, and some janky method signatures because both these methods acceptedincludeAllArgs:falseto be passed in.Instead of allowing for that flexibility, lets just hard-code
includeAllArgs:trueand simplify all the types along the way.Notice some improvements:
ApiResult<...>instead of manually writing out the tuplerequestData: any;andrequester: any;are gone, meaning we have typesafe params at the site of the method callsrequestData.fieldis doing, i didn't want to change it too much.injectedFields.pushseems pointless; but i'm not breaking it.ApiResulttuple with.then(([response]) => {...