ref: Make includeAllArgs mandatory in doEventsRequest() and iterate on types
#87682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
scttcper
approved these changes
Mar 24, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Mar 27, 2025
…te on types (#87682) `doEventsRequest()` previously allowed the prop `includeAllArgs` to be optional, and was typed based on whether that field was set to `true` or `false | undefined`. Now the field is required, no longer optional. I also made sure to be explicit about setting the generic, so TS doesn't have to infer it, in order to make all the callsites as explicit as possible. So you don't need to look at `props` or something to figure out what the return type will be. The async test stuff seemed to improve some flakeyness I was seeing too.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doEventsRequest()previously allowed the propincludeAllArgsto be optional, and was typed based on whether that field was set totrueorfalse | undefined.Now the field is required, no longer optional.
I also made sure to be explicit about setting the generic, so TS doesn't have to infer it, in order to make all the callsites as explicit as possible. So you don't need to look at
propsor something to figure out what the return type will be.The async test stuff seemed to improve some flakeyness I was seeing too.