fix(superuser): Being superuser:read even if you're org owner results in fewer permissions #87689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in fewer permissions
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #87689 +/- ##
===========================================
+ Coverage 51.76% 67.99% +16.22%
===========================================
Files 9882 9885 +3
Lines 561062 561429 +367
Branches 22134 22134
===========================================
+ Hits 290421 381725 +91304
+ Misses 270240 179303 -90937
Partials 401 401 |
|
Is this a recent regression? |
cathteng
approved these changes
Mar 24, 2025
| result = self.from_request(request, self.org) | ||
| assert result.scopes == SUPERUSER_READONLY_SCOPES | ||
| assert result.scopes == set(member.get_scopes()).union(SUPERUSER_READONLY_SCOPES) | ||
|
|
||
| # readonly scopes does not override owner scopes if passed in |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Mar 27, 2025
… in fewer permissions (#87689) If you're in superuser mode with only `superuser.read` permissions, and you're browsing a Sentry organization where you're the owner, you'll find that you have fewer permissions than expected. ### Before  ### After  --------- Co-authored-by: Raj Joshi <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you're in superuser mode with only
superuser.readpermissions, and you're browsing a Sentry organization where you're the owner, you'll find that you have fewer permissions than expected.Before
After