feat(nav): Add quota exceeded alert#88037
Merged
isabellaenriquez merged 20 commits intomasterfrom Apr 7, 2025
Merged
Conversation
github-actions
bot
added
the
Scope: Frontend
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky tests
To view more test analytics, go to the Test Analytics Dashboard |
dashed
approved these changes
Apr 2, 2025
malwilley
reviewed
Apr 2, 2025
| handleRequestSent={() => {}} | ||
| /> | ||
| <DismissContainer> | ||
| <Checkbox |
Member
There was a problem hiding this comment.
Would it make more sense for this to be a button? A checkbox that immediately dismisses doesn't make sense to me
Contributor
Author
There was a problem hiding this comment.
This comes straight from design but definitely something I can ask the team about (ie. if we're hardset on a checkbox)
vbro
approved these changes
Apr 2, 2025
malwilley
reviewed
Apr 2, 2025
malwilley
approved these changes
Apr 2, 2025
Member
malwilley
left a comment
malwilley
left a comment
There was a problem hiding this comment.
Looks good - thank you responding to all my comments!
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
This PR implements the new sidebar quota alert. This PR also changes the incident status sidebar item to use the fire icon. A follow up PR will implement the auto-open behavior when not all prompts have been dismissed. https://github.com/user-attachments/assets/e0790bfe-1b03-4b57-9945-84e640eb8ef9 ### light mode  ### dark mode  Waiting on getsentry/getsentry#17118
Christinarlong
pushed a commit
that referenced
this pull request
Apr 10, 2025
This PR implements the new sidebar quota alert. This PR also changes the incident status sidebar item to use the fire icon. A follow up PR will implement the auto-open behavior when not all prompts have been dismissed. https://github.com/user-attachments/assets/e0790bfe-1b03-4b57-9945-84e640eb8ef9 ### light mode  ### dark mode  Waiting on getsentry/getsentry#17118
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the new sidebar quota alert. This PR also changes the incident status sidebar item to use the fire icon.
A follow up PR will implement the auto-open behavior when not all prompts have been dismissed.
quota.alert.demo.2.mov
light mode
dark mode
Waiting on https://github.com/getsentry/getsentry/pull/17118