fix(aci): type tsdb_function correctly, don't use as class var #88038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
wedamija
reviewed
Mar 26, 2025
| @@ -460,6 +474,7 @@ def batch_query( | |||
| model = get_issue_tsdb_group_model(category) | |||
| # InvalidFilter should not be raised for errors | |||
| results = self.get_chunked_result( | |||
| tsdb_function=tsdb.backend.get_sums, | |||
There was a problem hiding this comment.
Nice, this seems simpler and you don't really need to declare them on the class level anyway.
ceorourke
approved these changes
Mar 27, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes SENTRY-3R0P
The
Delegatoris added in getsentry, and has additional checks to make sure backend service functions are used correctly.When
tsdb_functionis used as aClassVar, callingself.tsdb_function()will passselfas an extra argument into the function, which causes the error. Use thetsdb_functionsdirectly instead of storing them as class vars, and improve typing for these functions.