-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat(issue-views): Add 'All Views' page #88043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌ 2 Tests Failed:
View the top 2 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! Tiny bug I noticed is that the cache for visibility='owner' isn't updated when you click on New View, so you won't see it in the All View page until a page refresh. But I think that makes sense since we'll be changing how add view works pretty soon.
${p => | ||
p.isFirst && | ||
css` | ||
border-top: 1px solid ${p.theme.border}; | ||
`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would :first-child work here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately not because the header will be the first child :/
Don't think there's a good way to do this in CSS
Depends on #88041
Adds the 'All Views' page when you have the
issue-view-sharing
feature flag enabled.Note that: