feat(issue-views): Add 'All Views' page#88043
Merged
Conversation
❌ 2 Tests Failed:
View the top 2 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
MichaelSun48
approved these changes
Mar 27, 2025
Contributor
MichaelSun48
left a comment
There was a problem hiding this comment.
This is awesome! Tiny bug I noticed is that the cache for visibility='owner' isn't updated when you click on New View, so you won't see it in the All View page until a page refresh. But I think that makes sense since we'll be changing how add view works pretty soon.
Comment on lines
+180
to
+184
| ${p => | ||
| p.isFirst && | ||
| css` | ||
| border-top: 1px solid ${p.theme.border}; | ||
| `} |
Contributor
There was a problem hiding this comment.
Would :first-child work here?
Member
Author
There was a problem hiding this comment.
Unfortunately not because the header will be the first child :/
Don't think there's a good way to do this in CSS
andrewshie-sentry
pushed a commit
that referenced
this pull request
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #88041
Adds the 'All Views' page when you have the
issue-view-sharingfeature flag enabled.Note that: