fix(uptime): have jsonpath asserts compare against values #471
+412
−79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of mapping "some results" -> true. This makes for a much easier experience for users. Also, re-jigger some comparison logic, especially for jsonpath tests, since we'll need to coerce based on what we get back.
wedamija
approved these changes
Jan 28, 2026
Comment on lines
+213
to
+226
| Comparison::LessThan => match self { | ||
| JSONPathOperand::None => false, | ||
| JSONPathOperand::Literal { value } => cmp_lt_json(v, value, gas)?, | ||
|
|
||
| JSONPathOperand::Glob { .. } => false, | ||
| }, | ||
| Comparison::GreaterThan => match self { | ||
| JSONPathOperand::None => false, | ||
| JSONPathOperand::Literal { value } => cmp_gt_json(v, value, gas)?, | ||
|
|
||
| JSONPathOperand::Glob { .. } => false, | ||
| }, | ||
| Comparison::Equal => cmp_eq_jsonpath(v, self, gas)?, | ||
| Comparison::NotEqual => !cmp_eq_jsonpath(v, self, gas)?, |
Member
There was a problem hiding this comment.
Do all of these comparisons have tests that validate them? I didn't see it in the new tests, but wasn't sure if they already existed
| super::JSONPathOperand::Literal { value } => JSONPathOperand::Literal { | ||
| value: value.clone(), | ||
| }, | ||
| super::JSONPathOperand::Glob { pattern: value } => { |
Member
There was a problem hiding this comment.
Same question here about whether this has tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of mapping "some results" -> true. This makes for a much easier experience for users. Also, re-jigger some comparison logic, especially for jsonpath tests, since we'll need to coerce based on what we get back.