Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fragments #5208

Merged
merged 2 commits into from
Mar 12, 2025
Merged

Add Fragments #5208

merged 2 commits into from
Mar 12, 2025

Conversation

malfisya
Copy link
Member

@malfisya malfisya commented Mar 9, 2025

Summary

  • fragments: Add at v3.0.1
  • transmission: Split CLI component to a subpackage

Test Plan

Install and run all packages one by one

Checklist

  • Package was built and tested against unstable
  • This change could gainfully be listed in the weekly sync notes once merged

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
malfisya Muhammad Alfi Syahrin
**Summary**

The GTK client and the CLI can funtion independently,
split the CLI component so Fragments can depends on it

Verified

This commit was signed with the committer’s verified signature.
malfisya Muhammad Alfi Syahrin
**Summary**

Add fragments at v3.0.1

Resolves #5112
@EbonJaeger EbonJaeger added the Topic: Sync Notes This PR/Issue can be highlighted in sync notes label Mar 10, 2025
Copy link
Member

@EbonJaeger EbonJaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The transmission-cli package should probably depend on the base transmission package.

@malfisya
Copy link
Member Author

malfisya commented Mar 11, 2025

Not really, they work independently. I am actually quite surprised as well. The "base" package is actually the GUI version (not part). That's why I splitted it out, so fragments doesn't install another GUI torrent client.

Copy link
Member

@EbonJaeger EbonJaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@EbonJaeger EbonJaeger merged commit 88a7679 into main Mar 12, 2025
1 check passed
@EbonJaeger EbonJaeger deleted the fragments branch March 12, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Topic: Sync Notes This PR/Issue can be highlighted in sync notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants