Skip to content

SDK-2675: Checks should not populate the report property, if all of t… #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2025
Merged

SDK-2675: Checks should not populate the report property, if all of t… #501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...java/com/yoti/api/client/sandbox/docs/request/check/SandboxDocumentAuthenticityCheck.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
package com.yoti.api.client.sandbox.docs.request.check;

import static com.yoti.api.client.spi.remote.util.Validation.notNull;

import com.yoti.api.client.sandbox.docs.request.SandboxDocumentFilter;
import com.yoti.api.client.sandbox.docs.request.check.report.SandboxCheckReport;

Expand Down Expand Up @@ -30,7 +28,9 @@ protected Builder self() {

@Override
public SandboxDocumentAuthenticityCheck build() {
SandboxCheckReport report = new SandboxCheckReport(recommendation, breakdown);
SandboxCheckReport report = recommendation == null && breakdown == null
? null
: new SandboxCheckReport(recommendation, breakdown);
SandboxCheckResult result = new SandboxCheckResult(report, reportTemplate);

return new SandboxDocumentAuthenticityCheck(result, documentFilter);
Expand Down
6 changes: 3 additions & 3 deletions ...in/java/com/yoti/api/client/sandbox/docs/request/check/SandboxDocumentFaceMatchCheck.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
package com.yoti.api.client.sandbox.docs.request.check;

import static com.yoti.api.client.spi.remote.util.Validation.notNull;

import com.yoti.api.client.sandbox.docs.request.SandboxDocumentFilter;
import com.yoti.api.client.sandbox.docs.request.check.report.SandboxCheckReport;

Expand Down Expand Up @@ -30,7 +28,9 @@ protected Builder self() {

@Override
public SandboxDocumentFaceMatchCheck build() {
SandboxCheckReport report = new SandboxCheckReport(recommendation, breakdown);
SandboxCheckReport report = recommendation == null && breakdown == null
? null
: new SandboxCheckReport(recommendation, breakdown);
SandboxCheckResult result = new SandboxCheckResult(report, reportTemplate);

return new SandboxDocumentFaceMatchCheck(result, documentFilter);
Expand Down
6 changes: 3 additions & 3 deletions ...ain/java/com/yoti/api/client/sandbox/docs/request/check/SandboxDocumentTextDataCheck.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
package com.yoti.api.client.sandbox.docs.request.check;

import static com.yoti.api.client.spi.remote.util.Validation.notNull;

import java.util.HashMap;
import java.util.Map;

Expand Down Expand Up @@ -57,7 +55,9 @@ protected Builder self() {

@Override
public SandboxDocumentTextDataCheck build() {
SandboxCheckReport report = new SandboxCheckReport(recommendation, breakdown);
SandboxCheckReport report = recommendation == null && breakdown == null
? null
: new SandboxCheckReport(recommendation, breakdown);
SandboxDocumentTextDataCheckResult result = new SandboxDocumentTextDataCheckResult(report, reportTemplate, documentFields);

return new SandboxDocumentTextDataCheck(result, documentFilter);
Expand Down
6 changes: 3 additions & 3 deletions .../main/java/com/yoti/api/client/sandbox/docs/request/check/SandboxFaceComparisonCheck.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
package com.yoti.api.client.sandbox.docs.request.check;

import static com.yoti.api.client.spi.remote.util.Validation.notNull;

import com.yoti.api.client.sandbox.docs.request.check.report.SandboxCheckReport;

public class SandboxFaceComparisonCheck extends SandboxCheck {
Expand All @@ -28,7 +26,9 @@ protected Builder self() {

@Override
public SandboxFaceComparisonCheck build() {
SandboxCheckReport report = new SandboxCheckReport(recommendation, breakdown);
SandboxCheckReport report = recommendation == null && breakdown == null
? null
: new SandboxCheckReport(recommendation, breakdown);
SandboxCheckResult result = new SandboxCheckResult(report, reportTemplate);

return new SandboxFaceComparisonCheck(result);
Expand Down
6 changes: 3 additions & 3 deletions ...java/com/yoti/api/client/sandbox/docs/request/check/SandboxIdDocumentComparisonCheck.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
package com.yoti.api.client.sandbox.docs.request.check;

import static com.yoti.api.client.spi.remote.util.Validation.notNull;

import com.yoti.api.client.sandbox.docs.request.SandboxDocumentFilter;
import com.yoti.api.client.sandbox.docs.request.check.report.SandboxCheckReport;

Expand Down Expand Up @@ -41,7 +39,9 @@ protected Builder self() {

@Override
public SandboxIdDocumentComparisonCheck build() {
SandboxCheckReport report = new SandboxCheckReport(recommendation, breakdown);
SandboxCheckReport report = recommendation == null && breakdown == null
? null
: new SandboxCheckReport(recommendation, breakdown);
SandboxCheckResult result = new SandboxCheckResult(report, reportTemplate);

return new SandboxIdDocumentComparisonCheck(result, secondaryDocumentFilter);
Expand Down
6 changes: 3 additions & 3 deletions ...ava/com/yoti/api/client/sandbox/docs/request/check/SandboxStaticLivenessCheckBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
package com.yoti.api.client.sandbox.docs.request.check;

import static com.yoti.validation.Validation.notNull;

import com.yoti.api.client.docs.DocScanConstants;
import com.yoti.api.client.sandbox.docs.request.check.report.SandboxCheckReport;

Expand All @@ -23,7 +21,9 @@ protected SandboxStaticLivenessCheckBuilder self() {

@Override
public SandboxLivenessCheck build() {
SandboxCheckReport report = new SandboxCheckReport(recommendation, breakdown);
SandboxCheckReport report = recommendation == null && breakdown == null
? null
: new SandboxCheckReport(recommendation, breakdown);
SandboxCheckResult result = new SandboxCheckResult(report, reportTemplate);

return new SandboxLivenessCheck(result, DocScanConstants.STATIC, responseDelay);
Expand Down
6 changes: 3 additions & 3 deletions ...yoti/api/client/sandbox/docs/request/check/SandboxSupplementaryDocumentTextDataCheck.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
package com.yoti.api.client.sandbox.docs.request.check;

import static com.yoti.api.client.spi.remote.util.Validation.notNull;

import java.util.HashMap;
import java.util.Map;

Expand Down Expand Up @@ -54,7 +52,9 @@ protected Builder self() {

@Override
public SandboxSupplementaryDocumentTextDataCheck build() {
SandboxCheckReport report = new SandboxCheckReport(recommendation, breakdown);
SandboxCheckReport report = recommendation == null && breakdown == null
? null
: new SandboxCheckReport(recommendation, breakdown);
SandboxSupplementaryDocumentTextDataCheckResult result = new SandboxSupplementaryDocumentTextDataCheckResult(report, reportTemplate, documentFields);

return new SandboxSupplementaryDocumentTextDataCheck(result, documentFilter);
Expand Down
6 changes: 3 additions & 3 deletions ...va/com/yoti/api/client/sandbox/docs/request/check/SandboxSynecticsIdentityFraudCheck.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
package com.yoti.api.client.sandbox.docs.request.check;

import static com.yoti.api.client.spi.remote.util.Validation.notNull;

import com.yoti.api.client.sandbox.docs.request.check.report.SandboxCheckReport;

public class SandboxSynecticsIdentityFraudCheck extends SandboxCheck {
Expand All @@ -28,7 +26,9 @@ protected Builder self() {

@Override
public SandboxSynecticsIdentityFraudCheck build() {
SandboxCheckReport report = new SandboxCheckReport(recommendation, breakdown);
SandboxCheckReport report = recommendation == null && breakdown == null
? null
: new SandboxCheckReport(recommendation, breakdown);
SandboxCheckResult result = new SandboxCheckResult(report, reportTemplate);

return new SandboxSynecticsIdentityFraudCheck(result);
Expand Down
6 changes: 3 additions & 3 deletions ...n/java/com/yoti/api/client/sandbox/docs/request/check/SandboxThirdPartyIdentityCheck.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
package com.yoti.api.client.sandbox.docs.request.check;

import static com.yoti.api.client.spi.remote.util.Validation.notNull;

import com.yoti.api.client.sandbox.docs.request.check.report.SandboxCheckReport;

public class SandboxThirdPartyIdentityCheck extends SandboxCheck {
Expand Down Expand Up @@ -29,7 +27,9 @@ protected Builder self() {

@Override
public SandboxThirdPartyIdentityCheck build() {
SandboxCheckReport report = new SandboxCheckReport(recommendation, breakdown);
SandboxCheckReport report = recommendation == null && breakdown == null
? null
: new SandboxCheckReport(recommendation, breakdown);
SandboxCheckResult result = new SandboxCheckResult(report, reportTemplate);

return new SandboxThirdPartyIdentityCheck(result);
Expand Down
6 changes: 3 additions & 3 deletions ...om/yoti/api/client/sandbox/docs/request/check/SandboxThirdPartyIdentityFraudOneCheck.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
package com.yoti.api.client.sandbox.docs.request.check;

import static com.yoti.api.client.spi.remote.util.Validation.notNull;

import com.yoti.api.client.sandbox.docs.request.check.report.SandboxCheckReport;

public class SandboxThirdPartyIdentityFraudOneCheck extends SandboxCheck {
Expand All @@ -28,7 +26,9 @@ protected Builder self() {

@Override
public SandboxThirdPartyIdentityFraudOneCheck build() {
SandboxCheckReport report = new SandboxCheckReport(recommendation, breakdown);
SandboxCheckReport report = recommendation == null && breakdown == null
? null
: new SandboxCheckReport(recommendation, breakdown);
SandboxCheckResult result = new SandboxCheckResult(report, reportTemplate);

return new SandboxThirdPartyIdentityFraudOneCheck(result);
Expand Down
4 changes: 3 additions & 1 deletion .../java/com/yoti/api/client/sandbox/docs/request/check/SandboxWatchlistAdvancedCaCheck.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,9 @@ protected Builder self() {

@Override
public SandboxWatchlistAdvancedCaCheck build() {
SandboxCheckReport report = new SandboxCheckReport(recommendation, breakdown);
SandboxCheckReport report = recommendation == null && breakdown == null
? null
: new SandboxCheckReport(recommendation, breakdown);
SandboxCheckResult result = new SandboxCheckResult(report, reportTemplate);

return new SandboxWatchlistAdvancedCaCheck(result, sourcesFilter);
Expand Down
6 changes: 3 additions & 3 deletions ...n/java/com/yoti/api/client/sandbox/docs/request/check/SandboxWatchlistScreeningCheck.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
package com.yoti.api.client.sandbox.docs.request.check;

import static com.yoti.api.client.spi.remote.util.Validation.notNull;

import com.yoti.api.client.sandbox.docs.request.check.report.SandboxCheckReport;

public class SandboxWatchlistScreeningCheck extends SandboxCheck {
Expand All @@ -28,7 +26,9 @@ protected Builder self() {

@Override
public SandboxWatchlistScreeningCheck build() {
SandboxCheckReport report = new SandboxCheckReport(recommendation, breakdown);
SandboxCheckReport report = recommendation == null && breakdown == null
? null
: new SandboxCheckReport(recommendation, breakdown);
SandboxCheckResult result = new SandboxCheckResult(report, reportTemplate);

return new SandboxWatchlistScreeningCheck(result);
Expand Down
6 changes: 3 additions & 3 deletions .../java/com/yoti/api/client/sandbox/docs/request/check/SandboxZoomLivenessCheckBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
package com.yoti.api.client.sandbox.docs.request.check;

import static com.yoti.validation.Validation.notNull;

import com.yoti.api.client.docs.DocScanConstants;
import com.yoti.api.client.sandbox.docs.request.check.report.SandboxCheckReport;

Expand All @@ -23,7 +21,9 @@ public SandboxZoomLivenessCheckBuilder withResponseDelay(Integer responseDelay)

@Override
public SandboxLivenessCheck build() {
SandboxCheckReport report = new SandboxCheckReport(recommendation, breakdown);
SandboxCheckReport report = recommendation == null && breakdown == null
? null
: new SandboxCheckReport(recommendation, breakdown);
SandboxCheckResult result = new SandboxCheckResult(report, reportTemplate);

return new SandboxLivenessCheck(result, DocScanConstants.ZOOM, responseDelay);
Expand Down