SDK-2470 add brand_id to IDV SDK config #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurent-yoti
requested review from
MrBurtyyy,
jlmartyres,
dhivya-pattabhiraman,
saurabh-yoti,
mehmet-yoti and
abdalmajeed-yoti
laurent-yoti
commented
Jul 30, 2024
| * | ||
| * @returns {this} | ||
| */ | ||
| withBrandId(brandId) { |
There was a problem hiding this comment.
Not sure about what we want:
.withBrandID()
// or
.withBrandId()
laurent-yoti
changed the title
laurent-yoti
force-pushed
the
SDK-2470-add-brand-id-to-idv-sdk-config
branch
from
053a84d to
f936ce9
Compare
saurabh-yoti
approved these changes
Jul 30, 2024
abdalmajeed-yoti
approved these changes
Jul 30, 2024
jlmartyres
approved these changes
Jul 30, 2024
laurent-yoti
added a commit
that referenced
this pull request
Aug 9, 2024
Update idv_service to expose a `withBrandId` in the SDK config builder. (#487)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update idv_service to expose a
withBrandIdin the SDK config builder.