Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP add episode bulk #256

Merged
merged 1 commit into from
Jan 27, 2025
Merged

WIP add episode bulk #256

merged 1 commit into from
Jan 27, 2025

Conversation

prasmussen15
Copy link
Collaborator

@prasmussen15 prasmussen15 commented Jan 24, 2025

Important

Add add_episode_bulk() method in Graphiti class for bulk processing of episodes, marked as work-in-progress.

  • New Functionality:
    • Adds add_episode_bulk() method in Graphiti class in graphiti.py for processing multiple episodes in bulk.
    • Handles saving episodes, extracting nodes and edges, generating embeddings, deduplicating nodes and edges, and saving to the knowledge graph.
  • Limitations:
    • Does not perform edge invalidation or date extraction; use add_episode() for these operations.
  • Misc:
    • Method is marked as "WIP: USE AT YOUR OWN RISK" indicating it's a work-in-progress.

This description was created by Ellipsis for 9078f63. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 9078f63 in 11 seconds

More details
  • Looked at 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. graphiti_core/graphiti.py:484
  • Draft comment:
    The add_episode_bulk method is marked as WIP and has a warning comment. Ensure this is intentional and consider adding more details about the current limitations or areas that need work.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The method add_episode_bulk is marked as WIP and has a warning comment. This indicates that it might not be fully functional or tested. It's important to highlight this to the author.
2. graphiti_core/graphiti.py:485
  • Draft comment:
    Method names should follow a consistent pattern. Consider renaming add_episode_bulk to add_episodes_bulk for consistency with other method names in the class.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The method name 'add_episode_bulk' should follow the same naming pattern as other methods in the class, which use underscores to separate words. This ensures consistency in method naming.

Workflow ID: wflow_4DWHvtbFHhZXgdxV


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@prasmussen15 prasmussen15 merged commit d3b2cec into main Jan 27, 2025
7 checks passed
@prasmussen15 prasmussen15 deleted the wip-bulk-ingest branch January 27, 2025 14:52
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants