[Ellipsis] [BUG] Zep Admin console leaks database password #318
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Issue: #316
Implementation:
redactHTMLEncodeConfig
. Find the line with the regular expression(?i:postgres://[^:]+:)([^@]+)
. Replace this regular expression with(?i)(postgres://[^:]+:)([^@]+)
. This change moves the case-insensitive flag out of the first group, making it a capturing group and fixing the issue with the password not being redacted.(?i)(postgres://[^:]+:)([^@]+)
. Run the code and confirm that the password is correctly redacted from the DSN.Report:
Update the regular expression in redactHTMLEncodeConfig
Updated the regular expression in theredactHTMLEncodeConfig
function to correctly redact the Postgres password.Test the updated regular expression
Updated the regular expression in theredactHTMLEncodeConfig
function to correctly redact the Postgres password.Something look wrong?: If this Pull Request doesn't contain the expected changes, add more information to #316. Then, add the
ellipsis:create
label to try again. For more information, check the documentation.