-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert: Publish image action changes #362
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to 7222595 in 14 seconds
More details
- Looked at
14
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_PxlQF6udLaiz0l6a
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on fe2e2ef in 25 seconds
More details
- Looked at
82
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. .github/workflows/docker-publish.yml:23
- Draft comment:
The Depot CLI setup step is already present. Ensure this is intentional and not redundant with the new changes. - Reason this comment was not posted:
Confidence changes required:50%
The PR description mentions adding a Depot CLI setup step, but the workflow file already contains a step for setting up Depot CLI. This might be redundant or incorrectly described in the PR.
Workflow ID: wflow_5qdajjdTeNapx6oV
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Important
Adds Depot CLI setup to GitHub Actions workflow in
docker-publish.yml
, updating checkout and build steps.depot/setup-action@v1
indocker-publish.yml
.actions/checkout@v3
and modifies ref handling.This description was created by
for fe2e2ef. It will automatically update as commits are pushed.