Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add healthcheck to neo4j service #365

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Conversation

paul-paliychuk
Copy link
Collaborator

@paul-paliychuk paul-paliychuk commented Sep 25, 2024

Important

Adds a health check to the Neo4j service in docker-compose.ce.yaml and updates zep service dependencies to wait for Neo4j to be healthy.

  • Health Check:
    • Adds health check to neo4j service in docker-compose.ce.yaml using wget to check HTTP availability on port 7474.
    • Configures health check with interval: 1s, timeout: 10s, retries: 20, and start_period: 3s.
  • Dependencies:
    • Updates depends_on for zep service to wait for neo4j to be healthy before starting.

This description was created by Ellipsis for 99e14da. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 99e14da in 7 seconds

More details
  • Looked at 27 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. docker-compose.ce.yaml:67
  • Draft comment:
    Consider using curl instead of wget for the healthcheck test, as curl is more commonly available in container environments.
      test: curl -f http://localhost:7474 || exit 1
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The healthcheck test for Neo4j uses wget, which may not be available in all environments. Using curl or a direct command might be more reliable.

Workflow ID: wflow_JEWPpl9O00IRwJq4


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@paul-paliychuk paul-paliychuk merged commit 944a32c into main Sep 25, 2024
4 checks passed
@paul-paliychuk paul-paliychuk deleted the add-neo4j-healthcheck branch September 25, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants