Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add base url to ts snippet readme #367

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Conversation

paul-paliychuk
Copy link
Collaborator

@paul-paliychuk paul-paliychuk commented Sep 26, 2024

Important

Update README.md to change environment to baseUrl in TypeScript snippet for ZepClient.

  • Documentation:
    • In README.md, change environment to baseUrl in the TypeScript snippet for ZepClient initialization.

This description was created by Ellipsis for a1fbd66. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to a1fbd66 in 5 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. README.md:211
  • Draft comment:
    The change from environment to baseUrl is correct. Ensure that the rest of the documentation and code examples are consistent with this change.
  • Reason this comment was not posted:
    Confidence changes required: 10%
    The change from 'environment' to 'baseUrl' is correct based on the context of the ZepClient configuration.

Workflow ID: wflow_8CantQTrgCk3NwjR


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@paul-paliychuk paul-paliychuk merged commit 719fa0f into main Sep 26, 2024
4 checks passed
@paul-paliychuk paul-paliychuk deleted the update-ts-sdk-readme branch September 26, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant