Skip to content

Fix setting instance validation flags (fixed #533)#570

Merged
cwfitzgerald merged 2 commits into
gfx-rs:trunkfrom
lisyarus:fix-instance-validation-flags
Apr 5, 2026
Merged

Fix setting instance validation flags (fixed #533)#570
cwfitzgerald merged 2 commits into
gfx-rs:trunkfrom
lisyarus:fix-instance-validation-flags

Conversation

@lisyarus
Copy link
Copy Markdown
Contributor

@lisyarus lisyarus commented Apr 5, 2026

Checklist

  • cargo clippy reports no issues
  • cargo doc reports no issues
  • cargo deny issues have been fixed or added to deny.toml
  • Human-readable change descriptions added to CHANGELOG.md under the "Unreleased" heading.
    • If the change does not affect the user (or is a process change), preface the change with "Internal:"
    • Add credit to yourself for each change: Added new functionality. @githubname

I couldn't find the CHANGELOG.md file. Should I create it?
Also, it seems that the correct command is not cargo deny, but cargo deny check.

Description

This changes how instance flags are mapped to wgt::InstanceFlags. The behavior of old flags doesn't change, but now

  • An instance can actually be created with empty flags
  • Some new flags supported by wgt::InstanceFlags were added that were previously missing
  • Extra convenience bitfields were added that map to wgt::InstanceFlags::debugging()/advanced_debugging()/with_env()

Related issues

This fixes #533.

Copy link
Copy Markdown
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@cwfitzgerald cwfitzgerald merged commit 44aa8bb into gfx-rs:trunk Apr 5, 2026
35 checks passed
@lisyarus lisyarus deleted the fix-instance-validation-flags branch April 16, 2026 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Confusion regarding instance flags & validation

2 participants