Skip to content

common : remove json.hpp from common.cpp #12697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 2, 2025
Merged

common : remove json.hpp from common.cpp #12697

merged 2 commits into from
Apr 2, 2025

Conversation

ngxson
Copy link
Collaborator

@ngxson ngxson commented Apr 1, 2025 •
edited
Loading

Cont #12694

We can finally remove #include "json.hpp" from common.cpp

CC @ochafik I move the common_grammar_trigger::from/to_json to server because it's only used there.

Next: remove json from arg.cpp

@ngxson ngxson requested a review from ggerganov April 1, 2025 21:58
@ngxson ngxson merged commit 42eb248 into ggml-org:master Apr 2, 2025
51 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggerganov ggerganov ggerganov approved these changes

Assignees
No one assigned
Labels
examples server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ngxson @ggerganov