Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature: Integrate with unified SYCL backend for Intel GPUs #2690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Integrate with unified SYCL backend for Intel GPUs #2690
Changes from 53 commits
7a4343d
2338769
0c00b4f
ff83711
02dffb6
43f2c35
da752ed
6dd3278
3a9d2c5
65f895d
3b1a743
c2ef7a9
69d76c8
c709c3c
fa3a586
3645f25
bd38129
5b53899
a47f5ec
c67c2ab
c3c5b20
ca2cb69
95daece
a8936f4
79d30d7
0d6e721
7350fd4
09b5619
d80dd65
593ce00
57e9fba
d5f7d36
35a0daa
ae941b1
e3481fa
623d803
f396a3b
f008cc7
67e6b3c
533c647
dd7f139
b403784
a0a1304
27c08c0
97cbe18
1ddaf44
bd716b2
be31379
d097e2a
88f64b7
756c4ac
b42a32d
5f83a12
d6fc1a0
c7e745e
3bfb846
498121b
91b1461
816f480
7a44a95
7babd76
04a46c4
799af05
ec5c8bc
22e1b45
238ec31
67de350
fb15de3
96186a7
d07a88d
8dd1b60
3aabd8a
18742f7
0e235fb
5600118
eef5faa
5bb93d4
0635f84
f1bab50
66e24c2
b06dca6
05b7f9b
d6a6505
174c9a0
c08fec2
2cba564
f707051
45b0618
5531754
b9ffaab
2ab9715
d394ca7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How deep is the C++17 dependency in the SYCL backend?
It's okay to optionally include it like this, but I'm wondering if it is realistic to implement this in C++11 at some point - it would be in better harmony with the rest of the codebase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually the icpx compiler expects C++17 standard and SYCL has dependency on that version. We thought about this process having same version C++11 but it causes compilation errors due to dependency on c++17 headers.
@NeoZhangJianyu , @AidanBeltonS and others can add on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to add a bit more info, it is not just that the SYCL compiler, icpx, expects C++17. C++17 is a core aspect within the SYCL open standard. Any SYCL2020 code is expected to be C++17 conformant, so the relationship is deeper than just the specific implementation of the Khronos specification. I would say the dependency between SYCL and C++17 is hard, and it would likely not work well if SYCL specific features were compiled with C++11.
From the spec: https://registry.khronos.org/SYCL/specs/sycl-2020/pdf/sycl-2020.pdf
The SYCL specification is now based on the core language of C++17, as described in Section 3.9.1. Features of C++17 are now enabled within the specification, such as deduction guides for class template argument deduction