Don't rotate the player assigned to the role 'random' when generating…

[tflaherty]

… multiple matches

The current code rotates all players when generating multiple matches
for the same game. This change leaves the player associated with the
'random' role at the same index in the player list and rotates all the
other players. If there is no player associated with the 'random' role,
the code works as before.

[samschreiber]

Sorry for the slow response here. Was travelling; now catching up on everything I missed. This is on my radar.

[samschreiber]

Some initial thoughts:

• the code that computes the names of the roles for a given game seems like something that could be factored out, maybe even put in Game.java? (Also, I wish there were a way to do this which didn't require initializing an entire ProverStateMachine ... that feels very heavyweight, but maybe it's necessary to do this)
• I'm not sure this is the right level of abstraction to implement this -- in the future we may want the Game and StateMachine classes to understand the semantics of a "random" role, so that the applications built on top of that infrastructure (e.g. Server, Player, Kiosk, etc) aren't even aware that the "random" roles exist. This shouldn't deter us from starting by implementing this logic in Server; but eventually we may want to move it out into lower levels of the stack.

[tflaherty]

Sam, I agree with you on both points. I will spend some time on these and send along my proposed solutions. Do you plan on checking this in in the current state? It might take me a week or two to get back to this.

[tflaherty]

Sam, not a problem on the delay. I figured you might be on vacation or travelling.

[AlexLandau]

You can use Role#computeRoles for this.