Add support for OpenSuse 13.1 support. #30
Conversation
|
I'll fix the tests |
|
PR #31 should fix testing. Once it gets merged you would need to rebase against master. |
|
@buzzdeee Ready for you to rebase. |
buzzdeee
force-pushed
the
master
branch
2 times, most recently
from
668a9a7 to
5348599
Compare
|
Rebased, and both parameters updated in the README.md. Hope it's fine now for merge. |
|
|
||
| networks | ||
| -------- | ||
| String of list of sourcces for networks database. 'USE_DEFAULTS' allows the module to choose defaults based on the platform. |
|
Hi @buzzdeee This is looking great. Just need the two tests. Could you also please rebase your commits into one commit. Thanks |
|
Tests will look like ghoneycutt/puppet-module-ntp@0f9c3c1 only your testing that when it is a non-string, the failure occurs. |
|
@buzzdeee Hi, would you be able to add these tests? If not, I can add them. |
|
@ghoneycutt sorry, missed that, will take care about it next days ;) |
Added defaults based on a fresh OpenSuse 13.1 installation to init.pp. template got updated, to be able to manage other entries that were so far static in the file. Other OS/Distributions got updated to have the defaults as it was in the static template. Also mentioning it in README.md and metadata.json, and add spec test for it.
|
tests added as requested, and all squashed into one commit. cheers, |
|
sudoers support was recently merged. Could you please remove it from yours and rebase? |
Added defaults based on a fresh OpenSuse 13.1 installation to
init.pp. template got updated, to be able to manage other
entries that were so far static in the file.
Other OS/Distributions got updated to have the defaults
as it was in the static template.
Also mentioning it in README.md and metadata.json, and add
spec test for it.
ruby 1.8.7 spec tests are failing all the others are green, however,
I don't really think the changes are the culprit. Research showed, its
also happening to others:
lightblue-platform/lightblue-puppet#118