Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the logger more configurable #1471

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Make the logger more configurable #1471

merged 2 commits into from
Feb 8, 2024

Conversation

philipp-classen
Copy link
Member

To be used together with whotracksme/webextension-packages#64

The idea is to have log levels in two phases:

  • Startup: use the defaults that have been configured in the modules
  • Eventually, we get a result about a user defined overwrite and can apply it. If there is no overwrite, turn off logs.

Also, expose functions to temporarily overwrite the logging behavior.

@philipp-classen philipp-classen marked this pull request as draft February 7, 2024 17:29
@philipp-classen philipp-classen marked this pull request as ready for review February 7, 2024 17:31
@chrmod chrmod merged commit ab26917 into main Feb 8, 2024
2 checks passed
@chrmod chrmod deleted the improve_logs branch February 8, 2024 09:41
@smalluban smalluban mentioned this pull request Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants