fix(safari): use svg icon for toolbar #2284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smalluban
changed the title
smalluban
force-pushed
the
fix-safari-icon
branch
from
2a4797d to
d726ce4
Compare
|
Safari requires adding a slight border to the inactive icon - I've checked Firefox and Safari on macOS and iOS, and the border is not visible. |
chrmod
approved these changes
Mar 6, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2271.
It must be a Safari bug, as I saw a blurry icon of other extensions. Also, it is not well documented, that Safari has started supporting SVG format for a toolbar icon - when creating a new project in Xcode (https://developer.apple.com/documentation/safariservices/creating-a-safari-web-extension) the current default for action icon is SVG image.
I've checked iOS 17.x, iOS 18.x, and Safari 18.x on macOS, and it looks that all of them supports correctly SVG images.