Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cumulative update #1329

Merged
merged 9 commits into from
Jan 14, 2025
Merged

Cumulative update #1329

merged 9 commits into from
Jan 14, 2025

Conversation

ljakimczuk
Copy link
Contributor

@ljakimczuk ljakimczuk commented Jan 10, 2025

Description

Towards: https://github.com/giantswarm/giantswarm/issues/32280

Covers following Renovate PRs:

Merging the #1304 PR, for bumping the Kubernetes modules is not possible, due to OperatorKit mostly, whose latest versions uses the v.0.28.3 versions of the modules, whose API was different. For example, the OperatorKit declares error handlers as list of func(error) functions, in accordance to the APIMachinery v0.28.3, but the APIMachinery v0.32.0 changes type of the error handling function, although handlers remain a list, making the compilation throw an error. Hence bumping these packages does not seem possible unless we update OperatorKit, which is not not possible, or migrate away from it.

Checklist

  • Update changelog in CHANGELOG.md.

@ljakimczuk ljakimczuk marked this pull request as ready for review January 10, 2025 14:34
@ljakimczuk ljakimczuk requested a review from a team as a code owner January 10, 2025 14:34
Copy link
Member

@marians marians left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@ljakimczuk
Copy link
Contributor Author

The App Operator has been tested on garfish (Kubernetes v1.25.15) and golem (Kubernetes v1.29.9), all looks good.

@ljakimczuk ljakimczuk merged commit bfdec10 into main Jan 14, 2025
10 checks passed
@ljakimczuk ljakimczuk deleted the cumulative-update branch January 14, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants