Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a command to push to OCI registries #362
Add a command to push to OCI registries #362
Changes from 3 commits
f975c12
b256216
63f6f45
e7b95ef
f217995
0a2af48
5106a7b
ebd268a
9077793
0997c5f
32a6c37
9d90269
06aafe3
2894858
bf14abf
2173c44
d0a2074
447283e
035b929
884f614
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a stupid question: Where does helm actually come from here? Is it just installed by default? And should we verify that the version is recent enough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
architect-orb
usesarchitect
's Dockerfile as a base image. We install a bunch of binaries in that Dockerfile, including helm. I've recently updatedarchitect
(https://github.com/giantswarm/architect/pull/728/files), andarchitect-orb
is already using the latest release.