Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure gsoci.azurecr.io as the registry to use by default #196

Merged
merged 4 commits into from
Jan 10, 2024

Conversation

marians
Copy link
Member

@marians marians commented Dec 20, 2023

Towards

This PR replaces any occurrence of docker.io in values.yaml files with gsoci.azurecr.io,
to make the new ACR registry the default one.

@marians
Copy link
Member Author

marians commented Dec 20, 2023

@giantswarm/team-shield In this case I wasn't really sure which images can be pulled from gsoci.azurecr.io and which ones have to come from docker.io. I only changed the ones that have the giantswarm/ namespace prefix.

@marians marians marked this pull request as ready for review December 20, 2023 14:00
@marians marians requested a review from a team as a code owner December 20, 2023 14:00
@marians marians self-assigned this Dec 20, 2023
Copy link
Contributor

@Strigix Strigix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upstream charts don't need their image set, this will be overwritten by our app-level values.yaml.

@Strigix Strigix merged commit 0838358 into main Jan 10, 2024
5 checks passed
@Strigix Strigix deleted the app-values-registry-switch branch January 10, 2024 17:23
@marians
Copy link
Member Author

marians commented Jan 11, 2024

Thanks @Strigix ! Will there be a release any time soon, or should I trigger one?

@Strigix
Copy link
Contributor

Strigix commented Jan 12, 2024

I'll do a quick test to see if it pulls like it should, if yes. I'll release a patch today 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants