Add support for OCI registries #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@giantswarm/team-honeybadger PTAL. This is still pending a test, but the structure will overall stay the same. |
MarcelMue
reviewed
Apr 5, 2022
| helmregistry.ProvLayerMediaType, | ||
| } | ||
|
|
||
| var registryStore content.Registry |
There was a problem hiding this comment.
Can we make the content.Registry an optional value for the helmclient client struct?
That way we make our live easier down the road with private catalogs and such.
There was a problem hiding this comment.
This makes a lot of sense, sure.
|
Tested locally, pulling the chart works. I have a question or two to ask on the team's forum regarding some future-proofing of the design. |
rossf7
reviewed
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards giantswarm/roadmap#391
Checklist