-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define includeSelf template rendering function + consider missing default templates empty #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With config split we move the original include folder of the giantswarm/config repository to be a submodule in customer specific config repositories. In order to support customer specific include files we add support for the include-self directory. Includes from this folder can be imported by the new includeSelf function. Keeping include and adding includeSelf is better for error reporting and making it clear where the include is coming from instead of supporting fallbacks to find the file and masking error messages on problems.
… files instead of null
…en secret default template is empty or does not exist
Merged
1 task
675c954
to
5ef36c5
Compare
uvegla
added a commit
to giantswarm/management-cluster-bases
that referenced
this pull request
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards: giantswarm/roadmap#2456
With config split we move the original include folder of the giantswarm/config repository to
shared-configs
and customer specific config repositories.In order to support customer specific include files we add support for the include-self directory. Includes from this folder can be imported by the new includeSelf function.
Keeping include and adding includeSelf is better for error reporting and making it clear where the include is coming from instead of supporting fallbacks to find the file and masking error messages on problems.
Example folder structure:
And usage in config templates:
ℹ️ Additionally, missing default app templates are now considered empty instead of raising and error.
Checklist