added failed controller reconcilations metrics. #111
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stone-z
reviewed
May 29, 2024
internal/controller/metrics.go
Outdated
Comment on lines
8
to
24
| var ( | ||
| // FailedClusterPolicyControllerReconciliations is a Prometheus counter to keep track of the number of failed Cluster Policy Controller reconciliations. | ||
| FailedClusterPolicyControllerReconciliations = promauto.NewCounter(prometheus.CounterOpts{ | ||
| Name: "cluster_policy_controller_failed_reconciliations_total", | ||
| Help: "The total number of failed cluster policy controller reconciliations", | ||
| }) | ||
| // FailedPolicyExceptionControllerReconciliations is a Prometheus counter to keep track of the number of failed Policy Exception Controller reconciliations. | ||
| FailedPolicyExceptionControllerReconciliations = promauto.NewCounter(prometheus.CounterOpts{ | ||
| Name: "policy_exception_controller_failed_reconciliations_total", | ||
| Help: "The total number of failed policy exception controller reconciliations", | ||
| }) | ||
| // FailedPolicyManifestControllerReconciliations is a Prometheus counter to keep track of the number of failed Policy Manifest Controller reconciliations. | ||
| FailedPolicyManifestControllerReconciliations = promauto.NewCounter(prometheus.CounterOpts{ | ||
| Name: "policy_manifest_controller_failed_reconciliations_total", | ||
| Help: "The total number of failed policy manifest controller reconciliations", | ||
| }) | ||
| ) |
There was a problem hiding this comment.
I'd suggest having one metric and including the controller context as a label (related comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys,
can you please take a look whether this will work?
I've added metrics for failed reconciliations per controller.
Please check whether I've put the increases of the metrics on the right place if you've got time.
Other suggestions for possibly interesting metrics are more than welcome as well.
thank you